OpenStack Identity (keystone)

default_lock_timeout units are not documented

Bug #1434620 reported by Mark T. Voelker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Morgan Fainberg
OpenStack Identity (keystone) 2015.1.0 "kilo"

Bug Description

While helping debug a keystone performance issue recently, I worked with an operator who was seeing high lock contention times and thought that default_lock_timeout must have been specified in minutes. It's actually in seconds, but neither the docstring nor sample config file actually specify a unit of time:

# Default lock timeout for distributed locking. (integer
# value)
#default_lock_timeout=5

Mark T. Voelker (mvoelker)
Changed in keystone:
assignee: nobody → Mark T. Voelker (mvoelker)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/166304

Changed in keystone:
status: New → In Progress
OpenStack Infra (hudson-openstack)
Changed in keystone:
assignee: Mark T. Voelker (mvoelker) → Morgan Fainberg (mdrnstm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/166304
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=81d6caba2f8b3ba0083d4d375cf9154c58e858b3
Submitter: Jenkins
Branch: master

commit 81d6caba2f8b3ba0083d4d375cf9154c58e858b3
Author: Morgan Fainberg <email address hidden>
Date: Sat Mar 21 15:07:24 2015 -0700

    Specify time units for default_lock_timeout

    Currently, the docstring and sample config entries for
    default_lock_timeout do not specify what units of time the value uses
    (minutes, seconds, microseconds, etc). This patch adds units to make
    the value easier to understand for operators.

    Closes-Bug: #1434620
    DocImpact
    Change-Id: If6c587e24c13f8ea11725894bfa90a9027e34554

Changed in keystone:
status: In Progress → Fix Committed
Morgan Fainberg (mdrnstm)
Changed in keystone:
importance: Undecided → Low
milestone: none → kilo-rc1
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.