Designate

Delete zone process can be interrupted

Bug #1434189 reported by Tim Simmons
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
High
Tim Simmons
Designate 2015.1.0 "kilo"

Bug Description

The process of deleting a zone from Designate can be interrupted, leaving the zone in an unknown state on the DNS server.

Possible situations:
- A zone is deleted, and immediately updated. The Designate API does not prevent updates to deleting zones.
- Some zones are deleted, but before they have propagated, a Pool is updated, editing the NS records of every zone in the pool, including deleting zones.

Possible solutions:
- The API should not allow updates to deleting zones.
- The update pool logic should ignore deleting zones.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/165933

Changed in designate:
assignee: nobody → Tim Simmons (tim-simmons-t)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/165934

Tim Simmons (timsim)
Changed in designate:
milestone: none → liberty-1
milestone: liberty-1 → kilo-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/165933
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=117a857e70de82a7e78e5fdedda02db0fac0b7ce
Submitter: Jenkins
Branch: master

commit 117a857e70de82a7e78e5fdedda02db0fac0b7ce
Author: Tim Simmons <email address hidden>
Date: Thu Mar 19 15:45:07 2015 +0000

    Don't allow updates to zones that are being deleted

    *Disallows zone updates, record creates/updates/deletes to zones
    that have an action of 'DELETE'
    *Once someone hits delete on a zone, that should be it for that zone,
    allowing updates could keep it alive in a broken state

    Change-Id: If76de6dbc8c244552033256d8c758acda35526ea
    Partial-Bug: 1434189

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/165934
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=06c8f72ca1cdf112ab046032e3aee0c395eeac19
Submitter: Jenkins
Branch: master

commit 06c8f72ca1cdf112ab046032e3aee0c395eeac19
Author: Tim Simmons <email address hidden>
Date: Thu Mar 19 16:40:59 2015 +0000

    Omit deleting zones from mass ns record updates

    * When pools are updated or deleted, all the NS records for
    domains in those pools must be updated. This change omits zones
    that are being deleted from that process, as they are being deleted
    and don't need the update.
    * This serves another purpose, making sure that those deleted zones
    dont have their state changed mid-delete, which can keep them from
    being deleted.

    Change-Id: I398d596b49fb980a017b42d10f0f5e63b3bd7afb
    Partial-Bug: 1434189

Revision history for this message
Kiall Mac Innes (kiall) wrote :

@Tim - Can this be closed out with both changes merged?

Changed in designate:
importance: Undecided → High
Revision history for this message
Tim Simmons (timsim) wrote :

Yes it can.

Changed in designate:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in designate:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.