Ironic

Instance tear down fail with KeyError: 'is_whole_disk_image'

Bug #1432093 reported by Ramakrishnan G (rameshg87)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
High
Ramakrishnan G (rameshg87)
Ironic 2015.1.0 "kilo"

Bug Description

After fetching the latest version of Ironic, tear down of instance fail with the following error:

nic/common/states.py:183
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/eventlet/hubs/hub.py", line 457, in fire_timers
    timer()
  File "/usr/local/lib/python2.7/dist-packages/eventlet/hubs/timer.py", line 58, in __call__
    cb(*args, **kw)
  File "/usr/local/lib/python2.7/dist-packages/eventlet/greenthread.py", line 214, in main
    result = function(*args, **kwargs)
  File "/opt/stack/ironic/ironic/conductor/manager.py", line 777, in _do_node_tear_down
    task.process_event('error')
  File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 82, in __exit__
    six.reraise(self.type_, self.value, self.tb)
  File "/opt/stack/ironic/ironic/conductor/manager.py", line 769, in _do_node_tear_down
    task.driver.deploy.clean_up(task)
  File "/opt/stack/ironic/ironic/drivers/modules/pxe.py", line 472, in clean_up
    pxe_info = _get_image_info(node, task.context)
  File "/opt/stack/ironic/ironic/drivers/modules/pxe.py", line 270, in _get_image_info
    if node.driver_internal_info['is_whole_disk_image']:
KeyError: 'is_whole_disk_image'

Revision history for this message
Ramakrishnan G (rameshg87) (rameshg87) wrote :

Steps to reproduce:

1. Take Ironic code before https://review.openstack.org/#/c/150142/
2. Provision an instance
3. Update Ironic code to on or after https://review.openstack.org/#/c/150142/
4. Try tear down

It fails with the above error.

Ramakrishnan G (rameshg87) (rameshg87)
Changed in ironic:
assignee: nobody → Ramakrishnan G (rameshg87)
Jim Rollenhagen (jim-rollenhagen)
Changed in ironic:
status: New → Confirmed
importance: Undecided → High
milestone: none → kilo-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/165676

Changed in ironic:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/165676
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=92bebca8abae9d8b1f261fda48296f9e65346c86
Submitter: Jenkins
Branch: master

commit 92bebca8abae9d8b1f261fda48296f9e65346c86
Author: Ramakrishnan G <email address hidden>
Date: Thu Mar 19 02:18:57 2015 +0000

    is_whole_disk_image might not exist for previous instances

    For newly created instances, we assume that 'is_whole_disk_image'
    should exist as it is populated by the conductor before every
    deploy. But it might not exist for instances create before
    whole disk image support (as it was introduced in this feature).
    We should assume that it's a partition image during tear down or
    takeover of these nodes and not fail.

    Closes-bug: 1432093
    Change-Id: If347a6d64be8bf4959195b9c68293c5ee9d40b48

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.