neutron

always-true conditional in portsecurity_db

Bug #1429754 reported by YAMAMOTO Takashi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
YAMAMOTO Takashi
neutron 2015.1.0 "kilo"

Bug Description

portsecurity_db has a dubious conditional "attrs.is_attr_set('security_group')", which seems always true.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/162563

Changed in neutron:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/162563
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3b0544757724fecbe7b6045b8126c40c4251a22e
Submitter: Jenkins
Branch: master

commit 3b0544757724fecbe7b6045b8126c40c4251a22e
Author: YAMAMOTO Takashi <email address hidden>
Date: Mon Mar 9 17:35:05 2015 +0900

    portsecurity_db: Fix a usage of is_attr_set

    I believe this is the intention of the original change.
    commit a5ccc2358dcc2cee5bc8db6a4448f58bae40b67b

    Also, add a test case which would have revealed the problem.

    Closes-Bug: #1429754
    Change-Id: I1481492404e7388b145860820a308452da24e24f

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.