register() function is a public API without tests and has changed
Bug #1428826 reported by
Benji York
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Landscape Client |
Fix Released
|
High
|
Benji York | ||
| landscape-client (Ubuntu) |
New
|
Undecided
|
Unassigned | ||
| Trusty |
New
|
Undecided
|
Unassigned | ||
Bug Description
The client's register() function is used by the charm [and other things?], but the API presented by that function (especially it's signature) is not enforced in tests in order to give early warning that changes will be disruptive.
In fact, just such a change was recently made by lp:~benji/landscape-client/better-self-signed-cert-ux-3
I will add tests for register()'s parameters and result and make the current parameter list compatible with the charm.
Related branches
lp://staging/~benji/landscape-client/bug-1428826-restore-register-function-public-API
- Adam Collard (community): Approve
- Björn Tillenius (community): Approve
-
Diff: 168 lines (+91/-18)2 files modifiedlandscape/configuration.py (+25/-15)
landscape/tests/test_configuration.py (+66/-3)
| tags: | removed: kanban |
| Changed in landscape-client: | |
| status: | In Progress → Fix Committed |
| Changed in landscape-client: | |
| milestone: | none → 15.04 |
| Changed in landscape-client: | |
| status: | Fix Committed → Fix Released |
| Changed in landscape-client: | |
| status: | Fix Released → Fix Committed |
| Changed in landscape-client: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
