Merlin

[WB] Workbook description field is missed

Bug #1428730 reported by Anastasia Kuznetsova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Merlin
Fix Committed
Medium
Timur Sufiev

Bug Description

Although workbook definition is optional field, it is presented in YAML workbook definition, but there is no input form to provide it.

Revision history for this message
Anastasia Kuznetsova (akuznetsova) wrote :
Revision history for this message
Nikolay Makhotkin (nmakhotkin) wrote :

Probably, did you mean 'description'?

Revision history for this message
Anastasia Kuznetsova (akuznetsova) wrote :

Yes, correct

summary: - [Workbook builder] Workbook definition field is missed
+ [Workbook builder] Workbook description field is missed
Revision history for this message
Timur Sufiev (tsufiev-x) wrote : Re: [Workbook builder] Workbook description field is missed

Happens from time to time on the document reload. Sometimes a description field is missing, sometimes both description and name (or version) are missing. Seems like some bug in Angular.js <-> Barricade.js interaction.

Changed in merlin:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Timur Sufiev (tsufiev-x) wrote :

Fixed with https://review.openstack.org/167563

Timur Sufiev (tsufiev-x)
Changed in merlin:
status: Triaged → In Progress
assignee: nobody → Timur Sufiev (tsufiev-x)
Timur Sufiev (tsufiev-x)
summary: - [Workbook builder] Workbook description field is missed
+ [WB] Workbook description field is missed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to merlin (master)

Reviewed: https://review.openstack.org/167563
Committed: https://git.openstack.org/cgit/stackforge/merlin/commit/?id=4bc01fe872c3ec27df9b92c4d00b7c9b25190be5
Submitter: Jenkins
Branch: master

commit 4bc01fe872c3ec27df9b92c4d00b7c9b25190be5
Author: Timur Sufiev <email address hidden>
Date: Wed Mar 25 14:09:41 2015 +0300

    Fix the bug with asynchronous template loading

    Due to each field template being loaded asynchronously it was possible
    that some templates hadn't been put to the $templateCache by the time
    they were requested from it for rendering a field directive. This lead
    to some random field shown in the initial document not being rendered
    at all. Fix this problem by using promises, effectively delaying the
    field rendering until the moment the template is finally loaded. Using
    promises also allows to not use $templateCache at all - the
    templateContents are passed as resolve() method argument.

    Also add 'ng-cloak' directive to the toplevel Workbook div to prevent
    raw Angular template flickering during initial load.

    Change-Id: I8a52b9730b52d4dd20400460137576713c081867
    Closes-Bug: #1428730

Changed in merlin:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.