OpenStack Identity (keystone)

Domain Config updates for specific group/option don't honor NotFound

Bug #1428600 reported by Henry Nash
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
High
Henry Nash
OpenStack Identity (keystone) 2015.1.0 "kilo"

Bug Description

The manager API for domain-config database updates should raise a DomainConfigNotFound exception if an explicit group or option as been specified in the url (i.e. passed as a parameter to the manager method) and that group/option is not present in the existing config. Currently the code does check that

a) the group/option is one we support (i.e. whitelisted or sensitive), and
b) the contents of the new config passed contains (and ONLY contains) the specified group or option

...but it doesn't check that the group/option exists in the original config.

See original description
Henry Nash (henry-nash)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/161718

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/161718
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=6f6d3cecadb7434a7b632ed9654b90382a3011be
Submitter: Jenkins
Branch: master

commit 6f6d3cecadb7434a7b632ed9654b90382a3011be
Author: Henry Nash <email address hidden>
Date: Thu Mar 5 13:58:06 2015 +0000

    Add checking for existing group/option to update domain config

    The current checks when updating a domain config missed the
    fact that if an explict group or option was specified, then it
    must already exist in the current config. If not, then a
    NotFound exception should be raised.

    Change-Id: I42c46b1bc6d7fde37b430dbe5eaba9a0ad7e5a75
    Closes-bug: 1428600

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.