neutron

need to add mandatory parameters for Router Info in vArmour fwaas agent

Bug #1427465 reported by Assaf Muller
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
badveli_vishnuus
neutron 2015.1.0 "kilo"

Bug Description

https://github.com/openstack/neutron-fwaas/blob/master/neutron_fwaas/services/firewall/agents/varmour/varmour_router.py#L64

vArmour L3 agent _router_added is calling neutron.agent.l3.router_info.RouterInfo__init__ and its not passing mandatory parameters (interface_driver, agent_conf). These parameters were introduced in change IDs:

I33a23eb37678d94cea3ace8afe090935b1e70685
I0ec75d731d816955c1915e283a137abcb51ac232

The unit tests that would catch this error:

https://github.com/openstack/neutron-fwaas/blob/master/neutron_fwaas/tests/unit/services/firewall/drivers/varmour/test_varmour_fwaas.py#L153

Are being skipped at the gate (Which is essentially another bug, why do these unit tests require a REST call to succeed, and are failing to complete the REST call with the default configuration?)
https://github.com/openstack/neutron-fwaas/blob/master/neutron_fwaas/tests/unit/services/firewall/drivers/varmour/test_varmour_fwaas.py#L182

Finally, 3rd party vArmour CI is not being run.

badveli_vishnuus (badveli-vishnuus)
Changed in neutron:
assignee: nobody → badveli_vishnuus (badveli-vishnuus)
Revision history for this message
badveli_vishnuus (badveli-vishnuus) wrote :

Thanks Assaf Muller
I had added the mandatory parameters and will post the patch.
Thanks
Vishnu

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas (master)

Fix proposed to branch: master
Review: https://review.openstack.org/161424

Changed in neutron:
status: New → In Progress
Revision history for this message
badveli_vishnuus (badveli-vishnuus) wrote : Re: vArmour fwaas agent broken, unit tests skipped, CI not running

vArmourCI is already running.

badveli_vishnuus (badveli-vishnuus)
summary: - vArmour fwaas agent broken, unit tests skipped, CI not running
+ need to add mandatory parameters for Router Info in vArmour fwaas agent
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → kilo-rc1
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/161424
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=29adb577a7172322f8c9fd0555c525c16b7b597f
Submitter: Jenkins
Branch: master

commit 29adb577a7172322f8c9fd0555c525c16b7b597f
Author: badveli_vishnuus <email address hidden>
Date: Tue Mar 17 18:52:00 2015 -0700

    Adding mandatory parameters for Router Info in vArmour fwaas agent

    This commit adds the mandatory parameters for Router Info
    introduced recently.
    Change-Id: I9d0af2e3291c8baa2e8944b3d9841126dbe5a4ec
    Closes-Bug:1427465

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.