agent-update: wrong help message for AGENT arg "ID or name of agent to update"

Bug #1424474 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-neutronclient
Fix Released
Medium
Akihiro Motoki

Bug Description

agent-update command takes only ID to specify an agent, but the help message says "ID or name".

(.venv)ubuntu@dev07:~/python-neutronclient (master)$ neutron help agent-update
usage: neutron agent-update [-h] [--request-format {json,xml}]
                            [--admin-state-down] [--description DESCRIPTION]
                            AGENT

Updates the admin status and description for a specified agent.

positional arguments:
  AGENT ID or name of agent to update.

optional arguments:
  -h, --help show this help message and exit
  --request-format {json,xml}
                        The XML or JSON request format.
  --admin-state-down Set admin state up of the agent to false.
  --description DESCRIPTION
                        Description for the agent.

Revision history for this message
Akihiro Motoki (amotoki) wrote :
affects: neutron → python-neutronclient
Changed in python-neutronclient:
status: New → In Progress
Kyle Mestery (mestery)
Changed in python-neutronclient:
milestone: none → 2.4.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/158152
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=7b8c2247bc60ff291644cc9d464d2210a2ca60c6
Submitter: Jenkins
Branch: master

commit 7b8c2247bc60ff291644cc9d464d2210a2ca60c6
Author: Akihiro Motoki <email address hidden>
Date: Mon Feb 23 08:35:24 2015 +0900

    Honor allow_names in *-update command

    Previously the help message of *-update command says
    "ID or name" even if the command takes only ID.
    UpdateCommand get_parser should honor allow_names
    when generating the help message.

    Change-Id: I6053d80cea4e1012230d5a1e6d15608545134f20
    Closes-Bug: #1424474

Changed in python-neutronclient:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in python-neutronclient:
milestone: 2.4.0 → 2.3.12
Kyle Mestery (mestery)
Changed in python-neutronclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.