OpenStack Identity (keystone)

Backend role tests have duplicate test for get_role

Bug #1422994 reported by Henry Nash
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Henry Nash
OpenStack Identity (keystone) 2015.1.0 "kilo"

Bug Description

In test_backend.py, the backend role tests have a test for get_role as a stand alone test and the exact same test as part of test_role_crud:

https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_backend.py#L249-L252

These tests are being moved to the new backend unit framework - and this duplication should be removed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/156840

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/156840
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=3388b9e6ca7d52c81b1db157f222be71be4be76a
Submitter: Jenkins
Branch: master

commit 3388b9e6ca7d52c81b1db157f222be71be4be76a
Author: Henry Nash <email address hidden>
Date: Tue Feb 17 23:31:08 2015 +0000

    Remove duplicated test for get_role

    The postive test for get_role had its own test as well as the one
    as part of test_role_crud. This patch removes this duplication.

    Change-Id: Ida3b2486587209a094d971bed40e2dc54ab388b0
    Closes-bug: 1422994

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.