Mir

[enhancement] Add surface morph client API

Bug #1422522 reported by Chris Halse Rogers
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Medium
Daniel van Vugt
Mir 0.13.0
mir (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Add client API for a surface to morph between surface types/parameters.

Related branches

lp://staging/~vanvugt/mir/rename-api
PS Jenkins bot (community): Approve (continuous-integration)
Alberto Aguirre (community): Approve
Robert Carr (community): Approve
Alan Griffiths: Needs Fixing
Chris Halse Rogers: Needs Fixing
Diff: 696 lines (+307/-14)
26 files modified
examples/fingerpaint.c (+1/-0)
examples/progressbar.c (+5/-0)
include/client/mir_toolkit/mir_surface.h (+8/-0)
include/server/mir/frontend/surface.h (+14/-0)
include/server/mir/scene/null_surface_observer.h (+1/-0)
include/server/mir/scene/surface_observer.h (+1/-0)
src/client/mir_surface.cpp (+36/-0)
src/client/mir_surface.h (+8/-0)
src/client/mir_surface_api.cpp (+42/-0)
src/client/symbols.map (+2/-1)
src/protobuf/mir_protobuf.proto (+18/-0)
src/server/frontend/protobuf_message_processor.cpp (+4/-0)
src/server/frontend/session_mediator.cpp (+28/-0)
src/server/frontend/session_mediator.h (+5/-0)
src/server/scene/basic_surface.cpp (+20/-0)
src/server/scene/basic_surface.h (+4/-1)
src/server/scene/legacy_surface_change_notification.cpp (+5/-0)
src/server/scene/legacy_surface_change_notification.h (+1/-0)
src/server/scene/null_surface_observer.cpp (+1/-0)
src/server/symbols.map (+1/-0)
tests/acceptance-tests/test_client_surfaces.cpp (+24/-0)
tests/include/mir_test_doubles/mock_frontend_surface.h (+1/-0)
tests/include/mir_test_doubles/stub_scene_surface.h (+1/-0)
tests/unit-tests/scene/test_basic_surface.cpp (+24/-12)
tests/unit-tests/scene/test_legacy_scene_change_notification.cpp (+17/-0)
tests/unit-tests/scene/test_surface_stack.cpp (+35/-0)
lp://staging/~alan-griffiths/mir/first-pass-of-surface-spec-modification
Robert Carr (community): Approve
Kevin DuBois (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Thomas Voß (community): Approve
Alexandros Frantzis (community): Approve
Alberto Aguirre (community): Approve
Alan Griffiths: Abstain
Chris Halse Rogers: Approve
Diff: 397 lines (+184/-56)
9 files modified
include/client/mir_toolkit/mir_surface.h (+23/-3)
src/client/mir_surface.cpp (+1/-2)
src/client/mir_surface.h (+1/-3)
src/client/mir_surface_api.cpp (+41/-40)
src/client/symbols.map (+2/-0)
src/server/shell/canonical_window_manager.cpp (+36/-5)
src/server/shell/canonical_window_manager.h (+7/-0)
tests/acceptance-tests/test_client_surfaces.cpp (+3/-3)
tests/acceptance-tests/test_surface_modifications.cpp (+70/-0)
lp://staging/ubuntu/wily-proposed/mir
Chris Halse Rogers (raof)
Changed in mir:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Check with Qt and the Unity8 guys what syntax (parameters) will work for them. We don't want to build an API they can't use...

Changed in mir:
status: Triaged → Incomplete
Daniel van Vugt (vanvugt)
tags: added: enhancement
summary: - Add surface morph client API
+ [enhancement] Add surface morph client API
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I'm working on prerequisite stuff for this, and might even complete this part too.

Changed in mir:
assignee: nobody → Daniel van Vugt (vanvugt)
Daniel van Vugt (vanvugt)
tags: added: clientapi
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision 2437, scheduled for release in mir, milestone 0.13.0

Changed in mir:
status: Incomplete → Fix Committed
Revision history for this message
Gerry Boland (gerboland) wrote :

We'd like a little more than just window titles please :)

Changed in mir:
status: Fix Committed → Confirmed
Revision history for this message
Chris Halse Rogers (raof) wrote :

Yeah; this adds much of the underlying infrastructure for surface morphing, but doesn't actually expose a client API for it :)

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

"related branch" is linked for reference. It's not an implementation.

Daniel van Vugt (vanvugt)
Changed in mir:
status: Confirmed → Fix Committed
milestone: none → 0.13.0
Alan Griffiths (alan-griffiths)
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.13.1+15.10.20150520-0ubuntu1

---------------
mir (0.13.1+15.10.20150520-0ubuntu1) wily; urgency=medium

  [ Cemil Azizoglu ]
  * New upstream release 0.13.1 (https://launchpad.net/mir/+milestone/0.13.1)
    - ABI summary: No ABI break. Servers and clients do not need rebuilding.
      . Mirclient ABI unchanged at 8
      . Mircommon ABI unchanged at 4
      . Mirplatform ABI unchanged at 7
      . Mirserver ABI unchanged at 31
    - Bug fixes:
      . Can't load app purchase UI without a U1 account (LP: #1450377)
      . Crash because uncaught exception in mir::events::add_touch (LP: #1437357)

 -- CI Train Bot <email address hidden> Wed, 20 May 2015 21:20:15 +0000

Changed in mir (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.