Move money.billing timestamps back to moment of fine
Bug #1422379 reported by
Dan Wells
This bug affects 6 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Confirmed
|
Medium
|
Dan Wells |
Bug Description
Current code stamps billings into the future, with the underlying concept that the time represents when the billing ends, not when it begins. This is hard to understand, and requires frequent explanation to those not familiar with it. This is especially true for shorter fine intervals, such as hourly, as the last fine will clearly be dated after the checkin time.
Let's instead do the more natural thing and have the first billing timestamped one second after the due time (the time it actually happens now), then every fine interval after that.
Changed in evergreen: | |
milestone: | none → 2.8-beta |
Changed in evergreen: | |
milestone: | 2.next → 2.9-alpha |
Changed in evergreen: | |
milestone: | 2.9-alpha → 2.9-beta |
milestone: | 2.9-beta → none |
milestone: | none → 2.next |
milestone: | 2.next → 2.9-beta |
Changed in evergreen: | |
assignee: | nobody → Kathy Lussier (klussier) |
Changed in evergreen: | |
milestone: | 2.next → 2.10-beta |
Changed in evergreen: | |
assignee: | Kathy Lussier (klussier) → nobody |
Changed in evergreen: | |
assignee: | nobody → Michele Morgan (mmorgan) |
Changed in evergreen: | |
milestone: | 2.10-beta → 2.10-rc |
Changed in evergreen: | |
assignee: | nobody → Michele Morgan (mmorgan) |
Changed in evergreen: | |
status: | Triaged → Confirmed |
tags: |
added: circ-billing removed: billing |
To post a comment you must log in.
Branch available here:
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ dbwells/ lp1422379_ move_billing_ timestamps
working/ user/dbwells/ lp1422379_ move_billing_ timestamps
We've been running this code in production for approximately three weeks with no noted problems. The upgrade script in the branch is what we used in our system, but given the complexity of the money schema, it deserves some extra scrutiny.