get_pool scheduler API is poorly designed

Bug #1422042 reported by Clinton Knight
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
High
Clinton Knight

Bug Description

The scheduler API 'get_pools' was copied from Cinder and has several problems. The REST endpoint, /scheduler-stats/get_pools, is not a REST-appropriate name. The API allows filtering but filters are not currently supported by the Manila scheduler. The API was added as an extension, not part of the v1 API as it should be. After restarting the scheduler
service, the API doesn't return any data until a share has been created.

This bug must be fixed during Kilo, lest it become a breaking API change later.

Changed in manila:
assignee: nobody → Clinton Knight (clintonk)
status: New → In Progress
Changed in manila:
importance: Undecided → High
milestone: none → kilo-3
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/164360

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/164360
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=72f5f0485ae6a1dca53532844469e679885eacca
Submitter: Jenkins
Branch: master

commit 72f5f0485ae6a1dca53532844469e679885eacca
Author: Clinton Knight <email address hidden>
Date: Sat Feb 14 19:51:34 2015 -0500

    Fix issues with get_pool scheduler API

    The scheduler API 'get_pools' was copied from Cinder and has several
    problems. The REST endpoint, /scheduler-stats/get_pools, is not a
    REST-appropriate name. The API allows filtering but filters are not
    currently supported by the Manila scheduler. The API was added as an
    extension, not part of the v1 API as it should be. After restarting
    the scheduler service, the API doesn't return any data until a share
    has been created (Cinder was used as a model for fixing this one).
    This patch fixes all of these issues.

    Closes-Bug: #1422042
    Change-Id: I7e32efb5390fd4b0a62f644ca5a12dcad14d8a9b

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.