Mir

Nested display leaks its EGLContext

Bug #1418910 reported by Alexandros Frantzis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Low
Alexandros Frantzis
Mir 0.13.0
mir (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Because the EGLContext is current when we call eglTerminate() the context isn't really freed at that point and we end up leaking the EGLContext (a "still reachable" leak). Since we don't destroy and recreate the NestedDisplay (at least not currently) it's just memory leaked at process exit. Still, it would be good to fix, if only to clean up the valgrind output a bit and ease detection of other leaks.

A side note: The way the EGL resources are managed in NestedDisplay leaves a lot to be desired (and could lead to other leaks in case the display is reconfigured), but that's a problem for another bug/MP.

Related branches

lp://staging/~afrantzis/mir/fix-1418910-nested-egl-context-leak
Alan Griffiths: Approve
PS Jenkins bot (community): Approve (continuous-integration)
Robert Carr (community): Approve
Diff: 201 lines (+76/-19)
6 files modified
src/server/graphics/nested/nested_display.cpp (+2/-0)
tests/include/mir_test_doubles/mock_egl.h (+4/-0)
tests/mir_test_doubles/mock_egl.cpp (+10/-1)
tests/unit-tests/graphics/mesa/test_display_multi_monitor.cpp (+4/-0)
tests/unit-tests/graphics/nested/test_nested_display.cpp (+38/-18)
tests/unit-tests/graphics/offscreen/test_offscreen_display.cpp (+18/-0)
lp://staging/ubuntu/wily-proposed/mir
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.12.0

Changed in mir:
status: New → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.12.0
Kevin DuBois (kdub)
Changed in mir:
milestone: 0.12.0 → 0.13.0
Daniel van Vugt (vanvugt)
Changed in mir (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Alan Griffiths (alan-griffiths)
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.13.1+15.10.20150520-0ubuntu1

---------------
mir (0.13.1+15.10.20150520-0ubuntu1) wily; urgency=medium

  [ Cemil Azizoglu ]
  * New upstream release 0.13.1 (https://launchpad.net/mir/+milestone/0.13.1)
    - ABI summary: No ABI break. Servers and clients do not need rebuilding.
      . Mirclient ABI unchanged at 8
      . Mircommon ABI unchanged at 4
      . Mirplatform ABI unchanged at 7
      . Mirserver ABI unchanged at 31
    - Bug fixes:
      . Can't load app purchase UI without a U1 account (LP: #1450377)
      . Crash because uncaught exception in mir::events::add_touch (LP: #1437357)

 -- CI Train Bot <email address hidden> Wed, 20 May 2015 21:20:15 +0000

Changed in mir (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.