console process will not shutdown when the node is deleted

Bug #1418804 reported by chenglch
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
chenglch

Bug Description

when the ironic node is defined and use node-set-console-mode to make console open, the shellinaboxd process for that node will exist. If we don't use node-set-console-mode to set the console false, just use node-delete to delete the node directly, the console process for that node will not stop.

chenglch (chenglch)
Changed in ironic:
assignee: nobody → chenglch (chenglch)
Dmitry Tantsur (divius)
Changed in ironic:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Mark Goddard (mgoddard) wrote :

I'd like to see this fixed.

How are you planning to do it? A similar case is for the node's power state. For this, rather than explicitly setting the power state to the desired value, the node-delete request throws an exception if the state is incorrect. Perhaps this is a precedent to follow here?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/154758

Changed in ironic:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/154758
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=ab551a177426b05d29a706dd249292a047299c15
Submitter: Jenkins
Branch: master

commit ab551a177426b05d29a706dd249292a047299c15
Author: chenglch <email address hidden>
Date: Wed Feb 11 00:26:38 2015 -0500

    Stop console at first if console is enabled when destroy node

    Previously, when node was deleted with console enabled,
    the console process was not stopped.
    Now stop console at first, then delete the node.

    Closes-Bug: #1418804
    Change-Id: Ia994b20c42df0a1f2882889a1be6dd4f426ee569

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.