Mir

[regression] MIR_CLIENT_PERF_REPORT=log now shows "0" for the surface name

Bug #1415305 reported by Daniel van Vugt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Low
Cemil Azizoglu
Mir 0.13.0
mir (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

[regression] MIR_CLIENT_PERF_REPORT=log now shows "0" for the surface name

[1422416148.210834] perf: 0: 62.25 FPS, render time 0.66ms, buffer lag 45.76ms (3 buffers)
[1422416149.212501] perf: 0: 59.94 FPS, render time 0.21ms, buffer lag 49.87ms (3 buffers)
[1422416150.214149] perf: 0: 59.94 FPS, render time 0.23ms, buffer lag 49.84ms (3 buffers)
[1422416151.215843] perf: 0: 59.94 FPS, render time 0.24ms, buffer lag 49.83ms (3 buffers)
[1422416152.217541] perf: 0: 59.94 FPS, render time 0.24ms, buffer lag 49.84ms (3 buffers)
[1422416153.218587] perf: 0: 59.94 FPS, render time 0.19ms, buffer lag 49.85ms (3 buffers)
[1422416154.220881] perf: 0: 59.88 FPS, render time 0.21ms, buffer lag 49.90ms (3 buffers)

Previously "perf: 0:" was "perf: name_of_the_surface_set_by_client:".

Tags: regression

Related branches

lp://staging/~cemil-azizoglu/mir/fix-perf-report-surface-name-lp1415305
Alan Griffiths: Approve
PS Jenkins bot (community): Approve (continuous-integration)
Alberto Aguirre (community): Approve
Kevin DuBois (community): Approve
Daniel van Vugt: Approve
Diff: 340 lines (+81/-44)
12 files modified
src/client/buffer_stream.cpp (+4/-17)
src/client/buffer_stream.h (+2/-1)
src/client/client_buffer_stream_factory.h (+2/-2)
src/client/default_client_buffer_stream_factory.cpp (+26/-4)
src/client/default_client_buffer_stream_factory.h (+3/-3)
src/client/mir_screencast.cpp (+1/-1)
src/client/mir_surface.cpp (+1/-1)
tests/include/mir_test_doubles/mock_client_buffer_stream_factory.h (+4/-4)
tests/include/mir_test_doubles/stub_client_buffer_stream_factory.h (+4/-2)
tests/unit-tests/client/test_client_buffer_stream.cpp (+32/-7)
tests/unit-tests/client/test_client_mir_surface.cpp (+1/-1)
tests/unit-tests/client/test_mir_screencast.cpp (+1/-1)
lp://staging/ubuntu/wily-proposed/mir
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: 0.11.0 → none
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Bisected:

------------------------------------------------------------
revno: 2261 [merge]
author: Robert Carr <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Mon 2015-01-26 21:29:52 +0000
message:
  Factor a common buffer stream implementation out of MirScreencast and MirSurfa
ce.

  Approved by PS Jenkins bot, Alberto Aguirre, Chris Halse Rogers, Alexandros Fr
antzis.
------------------------------------------------------------

Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Took a look. It is using protobuf_bs.id() as perf report surface name which differentiates between surfaces within a client. So with multiwin, you get (0, 1, 2) :

[1422471924.629395] perf: 1: 61.44 FPS, render time 15.78ms, buffer lag 31.78ms (3 buffers)
[1422471924.630274] perf: 2: 61.44 FPS, render time 16.03ms, buffer lag 31.55ms (3 buffers)
[1422471924.631150] perf: 0: 62.31 FPS, render time 1.81ms, buffer lag 45.10ms (3 buffers)

It can be made to use MirSurface::name by passing it as an arg to make_{producer|consumer}_stream and then to BufferStream. Not sure if it's worth it, since it still identifies surfaces from a client.

Changed in mir:
status: Triaged → Won't Fix
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Well those numbers aren't useful to log for anyone. The point of logging the name is so you can see how each separate window of your app is performing...

This could still be a simple fix so worth leaving the door open.

Changed in mir:
status: Won't Fix → Triaged
Cemil Azizoglu (cemil-azizoglu)
Changed in mir:
assignee: nobody → Cemil Azizoglu (cemil-azizoglu)
Daniel van Vugt (vanvugt)
Changed in mir:
status: Triaged → In Progress
milestone: none → 0.11.0
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: 0.11.0 → 0.12.0
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.12.0

Changed in mir:
status: In Progress → Fix Committed
Kevin DuBois (kdub)
Changed in mir:
milestone: 0.12.0 → 0.13.0
Daniel van Vugt (vanvugt)
Changed in mir (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Alan Griffiths (alan-griffiths)
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.13.1+15.10.20150520-0ubuntu1

---------------
mir (0.13.1+15.10.20150520-0ubuntu1) wily; urgency=medium

  [ Cemil Azizoglu ]
  * New upstream release 0.13.1 (https://launchpad.net/mir/+milestone/0.13.1)
    - ABI summary: No ABI break. Servers and clients do not need rebuilding.
      . Mirclient ABI unchanged at 8
      . Mircommon ABI unchanged at 4
      . Mirplatform ABI unchanged at 7
      . Mirserver ABI unchanged at 31
    - Bug fixes:
      . Can't load app purchase UI without a U1 account (LP: #1450377)
      . Crash because uncaught exception in mir::events::add_touch (LP: #1437357)

 -- CI Train Bot <email address hidden> Wed, 20 May 2015 21:20:15 +0000

Changed in mir (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.