debug-hooks exit 1 , doesn't mark hook as failed

Bug #1415176 reported by Jorge Niedbalski
32
This bug affects 6 people
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
High
Horacio Durán
1.23
Fix Released
High
Horacio Durán
1.24
Fix Released
High
Horacio Durán

Bug Description

[Environment]

1.20.14-trusty-amd64

Distributor ID: Ubuntu
Description: Ubuntu 14.04.1 LTS
Release: 14.04
Codename: trusty

[Description]

Set a debug-hooks trace point into any unit

$ juju debug-hooks ceph-radosgw/0 identity-service-relation-changed

 Once jumped into the tmux session, exiting the session with 'exit' or 'exit 1' makes no difference.

According to the current documentation: https://juju.ubuntu.com/docs/authors-hook-debug.html , any exit code != 0
should mark the hook as failed and will require a 'juju resolved' in order to keep the hooks queue execution.

description: updated
tags: added: cts
Revision history for this message
Curtis Hovey (sinzui) wrote :

I don't think this example is correct for the problem described. Per bug 1221501, juju does not support debug-hooks with the install hook. Is this issue a problem with the other hooks?

tags: added: debug-hooks
Changed in juju-core:
status: New → Incomplete
description: updated
description: updated
Changed in juju-core:
status: Incomplete → New
Curtis Hovey (sinzui)
Changed in juju-core:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Kapil Thangavelu (hazmat) wrote : Re: [Bug 1415176] Re: debug-hooks exit 1 , doesn't mark hook as failed

noted a workaround i've been able to use in bug:1415176

On Tue, Jan 27, 2015 at 4:38 PM, Curtis Hovey <email address hidden> wrote:

> ** Changed in: juju-core
> Status: New => Triaged
>
> ** Changed in: juju-core
> Importance: Undecided => Medium
>
> --
> You received this bug notification because you are subscribed to juju-
> core.
> https://bugs.launchpad.net/bugs/1415176
>
> Title:
> debug-hooks exit 1 , doesn't mark hook as failed
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju-core/+bug/1415176/+subscriptions
>

Revision history for this message
Leonardo Borda (lborda) wrote :

Hi Kapil

Can you describe us the workaround you were able to use it?

Thank Leo

Ian Booth (wallyworld)
Changed in juju-core:
milestone: none → 1.24-alpha1
importance: Medium → High
Changed in juju-core:
assignee: nobody → Jorge Niedbalski (niedbalski)
status: Triaged → In Progress
Changed in juju-core:
assignee: Jorge Niedbalski (niedbalski) → nobody
status: In Progress → Confirmed
Changed in juju-core:
milestone: 1.24-alpha1 → 1.25.0
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

i found if i closed all the windows in tmux minus the hook window, i could exit 1 from that window and the hook would be marked as failed.

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

note this was also added to the original bug report on this issue https://bugs.launchpad.net/juju-core/+bug/1227954 filed in 2013.

Revision history for this message
Horacio Durán (hduran-8) wrote :
Revision history for this message
Horacio Durán (hduran-8) wrote :

1.24 got merged and http://reviews.vapour.ws/r/1590/ is proposed for master

Changed in juju-core:
assignee: nobody → Horacio Durán (hduran-8)
status: Confirmed → In Progress
Ian Booth (wallyworld)
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.