TestNetworkInterfaces fails on ppv64el unit tests

Bug #1413652 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
Critical
Michael Foord

Bug Description

A single test, TestNetworkInterfaces, consistently fails:
AIL: environ_whitebox_test.go:1083: TestNetworkInterfaces.pN47_github_com_juju_juju_provider_maas.environSuite

[LOG] 0:00.319 DEBUG juju.provider.maas node "/api/1.0/nodes/node1/" primary network interface is "eth0"
[LOG] 0:00.319 DEBUG juju.provider.maas node "/api/1.0/nodes/node1/" skipping disabled network interface "wlan0"
environ_whitebox_test.go:1094:
    c.Assert(netInfo, jc.DeepEquals, expectedInfo)
... obtained []network.InterfaceInfo = []network.InterfaceInfo{network.InterfaceInfo{DeviceIndex:2, MACAddress:"aa:bb:cc:dd:ee:f2", CIDR:"192.168.3.1/24", NetworkName:"", ProviderId:"", ProviderSubnetId:"Virt", VLANTag:0, InterfaceName:"vnet1", Disabled:false, NoAutoStart:false, ConfigType:"", Address:, DNSServers:[]network.Address(nil), GatewayAddress:, ExtraConfig:map[string]string(nil)}, network.InterfaceInfo{DeviceIndex:0, MACAddress:"aa:bb:cc:dd:ee:ff", CIDR:"192.168.1.1/24", NetworkName:"", ProviderId:"", ProviderSubnetId:"WLAN", VLANTag:0, InterfaceName:"wlan0", Disabled:true, NoAutoStart:false, ConfigType:"", Address:, DNSServers:[]network.Address(nil), GatewayAddress:, ExtraConfig:map[string]string(nil)}, network.InterfaceInfo{DeviceIndex:1, MACAddress:"aa:bb:cc:dd:ee:f1", CIDR:"192.168.2.1/24", NetworkName:"", ProviderId:"", ProviderSubnetId:"LAN", VLANTag:42, InterfaceName:"eth0", Disabled:false, NoAutoStart:false, ConfigType:"", Address:, DNSServers:[]network.Address(nil), GatewayAddress:, ExtraConfig:map[string]string(nil)}}
... expected []network.InterfaceInfo = []network.InterfaceInfo{network.InterfaceInfo{DeviceIndex:1, MACAddress:"aa:bb:cc:dd:ee:f1", CIDR:"192.168.2.1/24", NetworkName:"", ProviderId:"", ProviderSubnetId:"LAN", VLANTag:42, InterfaceName:"eth0", Disabled:false, NoAutoStart:false, ConfigType:"", Address:, DNSServers:[]network.Address(nil), GatewayAddress:, ExtraConfig:map[string]string(nil)}, network.InterfaceInfo{DeviceIndex:2, MACAddress:"aa:bb:cc:dd:ee:f2", CIDR:"192.168.3.1/24", NetworkName:"", ProviderId:"", ProviderSubnetId:"Virt", VLANTag:0, InterfaceName:"vnet1", Disabled:false, NoAutoStart:false, ConfigType:"", Address:, DNSServers:[]network.Address(nil), GatewayAddress:, ExtraConfig:map[string]string(nil)}, network.InterfaceInfo{DeviceIndex:0, MACAddress:"aa:bb:cc:dd:ee:ff", CIDR:"192.168.1.1/24", NetworkName:"", ProviderId:"", ProviderSubnetId:"WLAN", VLANTag:0, InterfaceName:"wlan0", Disabled:true, NoAutoStart:false, ConfigType:"", Address:, DNSServers:[]network.Address(nil), GatewayAddress:, ExtraConfig:map[string]string(nil)}}
... mismatch at [0].DeviceIndex: unequal; obtained 2; expected 1

The only suspect revision is
Commit dd51687 Merge pull request #1469 from voidspace/networkinterfaces-maas

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

This is one of these PPC failures which happen due to gccgo's different default map traversal order than golang-go.

The fix should be easy enough - the final result of NetworkInterfaces() should be always sorted (e.g. by DeviceIndex).
I've asked Michael to take care of this.

Changed in juju-core:
assignee: nobody → Michael Foord (mfoord)
Changed in juju-core:
status: Triaged → In Progress
Michael Foord (mfoord)
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: 1.23 → 1.23-beta1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.