Unnecessary checks when cleaning up a domain

Bug #1409211 reported by Samuel de Medeiros Queiroz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Samuel de Medeiros Queiroz

Bug Description

When an internal notification for cleaning up a domain is sent, the callback method get all users and groups of that domain (using filtering), in order to delete them.

After this, when iterating over the domain's users and groups, it re-verifies their domain_id, which is unnecessary. [1]

[1] https://review.openstack.org/#/c/125521/3/keystone/identity/core.py

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/146264

Changed in keystone:
assignee: nobody → Samuel de Medeiros Queiroz (samuel-z)
status: New → In Progress
Changed in keystone:
assignee: Samuel de Medeiros Queiroz (samueldmq) → Steve Martinelli (stevemar)
Changed in keystone:
assignee: Steve Martinelli (stevemar) → Samuel de Medeiros Queiroz (samueldmq)
importance: Undecided → Low
milestone: none → kilo-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/146264
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=7b3206a052ebc7d6fb38363bf0749a5b2f98c4dd
Submitter: Jenkins
Branch: master

commit 7b3206a052ebc7d6fb38363bf0749a5b2f98c4dd
Author: Samuel de Medeiros Queiroz <email address hidden>
Date: Sat Jan 10 02:03:50 2015 -0300

    Removes unnecessary checks when cleaning a domain

    When an internal notification for cleaning up a
    domain was sent, the callback method was checking
    the domain_id from users and groups, which is
    unnecessary since they were filtered by that
    value.

    Closes-Bug: #1409211

    Change-Id: I151e8c7af885a9b3681b08bc47de443910a753bb

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.