OpenStack Identity (keystone)

endpoint_group_update does parameter check after updating endpoint_group

Bug #1408930 reported by wanghong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
wanghong
OpenStack Identity (keystone) 2015.1.0 "kilo"
Juno
Fix Released
Medium
wanghong
OpenStack Identity (keystone) 2014.2.3

Bug Description

Refer to: https://github.com/openstack/keystone/blob/master/keystone/contrib/endpoint_filter/controllers.py#L192

This leads to a bug that data will be updated successfully although api returns 400.

wanghong (w-wanghong)
Changed in keystone:
assignee: nobody → wanghong (w-wanghong)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/146040

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/146040
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=663411b8e4f2333086335cadd651c05f2e4a9134
Submitter: Jenkins
Branch: master

commit 663411b8e4f2333086335cadd651c05f2e4a9134
Author: wanghong <email address hidden>
Date: Fri Jan 9 17:11:49 2015 +0800

    do parameter check before updating endpoint_group

    Currently, the update method of endpoint_group does parameter check
    after updating endpoint_group. This leads to a bug that invalid data
    will be updated successfully although api returns 400.

    Change-Id: I94c0034a7bed2fe5b6f183ae8ef8d82cba512344
    Closes-Bug: #1408930

Changed in keystone:
status: In Progress → Fix Committed
Brant Knudson (blk-u)
tags: added: juno-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/151560

Morgan Fainberg (mdrnstm)
Changed in keystone:
importance: Undecided → Medium
milestone: none → kilo-2
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (stable/juno)

Reviewed: https://review.openstack.org/151560
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=75ed605a49ac8395a350c07e10ef2e782a1dc5d6
Submitter: Jenkins
Branch: stable/juno

commit 75ed605a49ac8395a350c07e10ef2e782a1dc5d6
Author: wanghong <email address hidden>
Date: Fri Jan 9 17:11:49 2015 +0800

    do parameter check before updating endpoint_group

    Currently, the update method of endpoint_group does parameter check
    after updating endpoint_group. This leads to a bug that invalid data
    will be updated successfully although api returns 400.

    Change-Id: I94c0034a7bed2fe5b6f183ae8ef8d82cba512344
    Closes-Bug: #1408930
    (cherry picked from commit 663411b8e4f2333086335cadd651c05f2e4a9134)

Thierry Carrez (ttx)
Changed in keystone:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.