wrong formatting within tempest retry functionality

Bug #1408069 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
High
Valeriy Ponomaryov

Bug Description

When we get error with share creation and retry is enabled log message is combined. But formatting was with mistake.
It expected named/mapped formating but got positioned formatting.

Here is trace:

ft2.1: setUpClass (tempest.api.share.test_metadata.SharesMetadataTest)_StringException: Traceback (most recent call last):
  File "tempest/api/share/test_metadata.py", line 25, in setUpClass
    __, cls.share = cls.create_share()
  File "tempest/api/share/base.py", line 260, in create_share
    [{"args": args, "kwargs": kwargs}], with_resp=True)
  File "tempest/api/share/base.py", line 315, in create_shares
    "Trying create another." % d["share"]["id"])
TypeError: format requires a mapping

Got from test results:
http://logs.openstack.org/42/144342/6/check/gate-manila-tempest-dsvm-neutron-multibackend/70746fc/logs/testr_results.html.gz

Tags: tempest
tags: added: tempest
Changed in manila:
assignee: nobody → Valeriy Ponomaryov (vponomaryov)
importance: Undecided → High
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/145309

Changed in manila:
milestone: none → kilo-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/145309
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=acc00e30236ec190df478fcf3f31647b4aaec489
Submitter: Jenkins
Branch: master

commit acc00e30236ec190df478fcf3f31647b4aaec489
Author: vponomaryov <email address hidden>
Date: Tue Jan 6 21:16:20 2015 +0200

    Fix TypeError in tempest retry functionality

    When we get error with share creation and retry is enabled log message
    is combined. But formatting was with mistake. It expected named/mapped
    formating but got positioned formatting.

    Change-Id: If80a31beca54ac4193b7b72b8c49c928b18d356f
    Closes-Bug: #1408069

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.