conductor starts even if no drivers are loaded

Bug #1404994 reported by aeva black
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Ramakrishnan G (rameshg87)
Juno
Fix Released
Medium
Thom Leggett

Bug Description

The ironic-conductor process will start, even if no drivers are loaded. Drivers may fail to load due to a misconfiguration, missing dependency, or other issues.

If no drivers are loaded, the conductor process can not function, and should shut down with a helpful error message.

Logs and simple way to reproduce:

$ grep enabled_drivers etc/ironic/ironic.conf.local
enabled_drivers=

$ ironic-conductor -v --config-file=etc/ironic/ironic.conf.local
2014-12-22 13:39:11.384 29092 INFO ironic.common.driver_factory [-] Loaded the following drivers: []
2014-12-22 13:39:11.589 29092 INFO ironic.conductor.manager [-] Successfuly started conductor with hostname zebra.
2014-12-22 13:39:11.601 29092 INFO oslo.messaging._drivers.impl_rabbit [-] Connecting to AMQP server on localhost:5672
2014-12-22 13:39:11.611 29092 INFO oslo.messaging._drivers.impl_rabbit [-] Connected to AMQP server on 127.0.0.1:5672
2014-12-22 13:39:11.618 29092 INFO ironic.common.service [-] Created RPC server for service ironic.conductor_manager on host zebra.

$ ironic driver-list
+---------------------+----------------+
| Supported driver(s) | Active host(s) |
+---------------------+----------------+
+---------------------+----------------+

aeva black (tenbrae)
Changed in ironic:
status: New → Triaged
importance: Undecided → Medium
tags: added: low-hanging-fruit
Revision history for this message
Ramakrishnan G (rameshg87) (rameshg87) wrote :

I guess we are stopping conductor if any of the enabled driver's couldn't be loaded.
https://review.openstack.org/#/c/83572/

So this case is only when enabled_drivers is empty.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/143616

Changed in ironic:
assignee: nobody → Ramakrishnan G (rameshg87)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/143616
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=fcc1a328dfe937984a449ae4fe5a4c412466a00d
Submitter: Jenkins
Branch: master

commit fcc1a328dfe937984a449ae4fe5a4c412466a00d
Author: Ramakrishnan G <email address hidden>
Date: Wed Dec 17 05:35:35 2014 +0530

    Stop conductor if no drivers were loaded

    This change stops ironic-conductor from starting if
    no drivers were loaded.

    Change-Id: I815a43e999095cdea07c1cd642ddeeb919a2aa00
    Closes-Bug: 1404994

Changed in ironic:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/149959

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (stable/juno)

Reviewed: https://review.openstack.org/149959
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=5d43d3cca269be4fa0f3a615c9c7400b5c882dc5
Submitter: Jenkins
Branch: stable/juno

commit 5d43d3cca269be4fa0f3a615c9c7400b5c882dc5
Author: Ramakrishnan G <email address hidden>
Date: Wed Dec 17 05:35:35 2014 +0530

    Stop conductor if no drivers were loaded

    This change stops ironic-conductor from starting if
    no drivers were loaded.

    Change-Id: I815a43e999095cdea07c1cd642ddeeb919a2aa00
    Closes-Bug: 1404994
    (cherry picked from commit fcc1a328dfe937984a449ae4fe5a4c412466a00d)

tags: added: in-stable-juno
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.