Background color should not be hardcoded to pitch black
Bug #1403695 reported by
Sergey "Shnatsel" Davidoff
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Photos |
Fix Released
|
Medium
|
José M. Benítez | ||
Bug Description
Shotwell and Photos currently hardcode the image area background color as pitch black, #000.
That pitch black background is quite distracting when viewing photos, as seen in e.g. http://
Something along the lines of http://
Ideally we'd want that color defined by the theme, but a constant defined in build-time config file would work as a stop-gap measure.
Related branches
lp://staging/~jmiguelbenitez/pantheon-photos/fix-1403695
- Photos Devs: Pending requested
-
Diff: 189 lines (+35/-41)4 files modifiedsrc/Page.vala (+13/-20)
src/PhotoPage.vala (+5/-3)
src/editing_tools/EditingTools.vala (+15/-14)
src/editing_tools/StraightenTool.vala (+2/-4)
| Changed in pantheon-photos: | |
| status: | New → In Progress |
| assignee: | nobody → Daniel Fore (danrabbit) |
| Changed in pantheon-photos: | |
| milestone: | none → loki-beta1 |
Revision history for this message
| xapantu (xapantu) wrote | #1 |
| Changed in pantheon-photos: | |
| importance: | Undecided → Medium |
| status: | In Progress → Fix Committed |
Revision history for this message
| xapantu (xapantu) wrote | #2 |
| Changed in pantheon-photos: | |
| status: | Fix Committed → In Progress |
Revision history for this message
| Danielle Foré (danrabbit) wrote | #3 |
| Changed in pantheon-photos: | |
| status: | In Progress → Fix Committed |
| status: | Fix Committed → In Progress |
| status: | In Progress → Confirmed |
| assignee: | Daniel Fore (danrabbit) → nobody |
| Changed in pantheon-photos: | |
| assignee: | nobody → José M. Benítez (jmiguelbenitez) |
| status: | Confirmed → In Progress |
| Changed in pantheon-photos: | |
| milestone: | loki-beta1 → loki-alpha1 |
| status: | In Progress → Fix Committed |
| Changed in pantheon-photos: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in the checker background, still needs investigation for the single photo view background.