extend policy rules to have name attribute in api

Bug #1403683 reported by Aaron Rosen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
congress
Fix Released
Undecided
Amey Bhide

Bug Description

It would be nice if policy_rules also had a name attribute. For example adding --name port_security_group to the following command:

 openstack congress policy rule create classification --name port_security_group "port_security_group(port, security_group_name) :-neutron:ports(addr_pairs, security_groups, extra_dhcp_opts, binding_cap, status, name, admin_state_up, network_id, tenant_id, binding_vif, device_owner, mac_address, fixed_ips, port, device_id, binding_host_id1), neutron:ports.security_groups(security_groups, security_group_id), neutron:security_groups(tenant_id2, security_group_name, desc2, security_group_id)"

Add name here:
https://github.com/stackforge/congress/blob/master/congress/api/rule_model.py#L86

Extend db code to save name and generate migration:
https://github.com/stackforge/congress/blob/master/congress/db/db_policy_rules.py#L30
name = sa.Column(sa.String(255)

We'll also then need to update the python-congressclient to expose this name attribute and allow people to delete by name.

Amey Bhide (abhide)
Changed in congress:
assignee: nobody → Amey (abhide)
Amey Bhide (abhide)
Changed in congress:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to congress (master)

Fix proposed to branch: master
Review: https://review.openstack.org/147045

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to congress (master)

Reviewed: https://review.openstack.org/147045
Committed: https://git.openstack.org/cgit/stackforge/congress/commit/?id=d66676a758eabfd76d16eab9b596af1e4d10e239
Submitter: Jenkins
Branch: master

commit d66676a758eabfd76d16eab9b596af1e4d10e239
Author: Amey Bhide <email address hidden>
Date: Wed Jan 14 13:09:59 2015 -0800

    Extend policy rules to have name attribute in api

    Closes-Bug: #1403683
    Change-Id: I1b031c373fb7531eab7e599d3c63f0dbe05b8744

Changed in congress:
status: In Progress → Fix Committed
Revision history for this message
Janet Yu (jwy) wrote :

I believe we still need the last part from the description, "update the python-congressclient to expose this name attribute and allow people to delete by name". I'll open a bug for it under python-congressclient.

Tim Hinrichs (thinrichs)
Changed in congress:
milestone: none → kilo-3
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.