Skip polling cycle when no resources are found and some resources are required by the relevant pollster

Bug #1403505 reported by Eoghan Glynn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Low
Lena Novokshonova

Bug Description

This was originally supposed to be addressed by:

  https://review.openstack.org/132169

"Currently, the polling agent will poll and publish even if no resources
found. Although no samples will be published in publishing process, the
polling record will be recorded in log files, this is easy to mislead.
This change skip to publish and record a clear skip-polling hint in
log if no resources found."

However this change did not take into account that pollsters may have
no expectation of an explicit resource list, such as in the IPMI case.

Hence needed to be reverted to fix:

  https://launchpad.net/bugs/1403280

A correct fix would have some awareness of whether the target pollster
required a resource list at all in order to do useful work.

Eoghan Glynn (eglynn)
Changed in ceilometer:
importance: Undecided → Low
Dina Belova (dbelova)
Changed in ceilometer:
assignee: nobody → Lena Novokshonova (enovokshonova)
status: New → Confirmed
milestone: none → kilo-2
Eoghan Glynn (eglynn)
Changed in ceilometer:
assignee: Lena Novokshonova (enovokshonova) → Liusheng (liusheng)
Revision history for this message
Dina Belova (dbelova) wrote :

heh, sorry, just thought it'll be nice as a kind of training for Lena to work with pollsters :) for sure it's Liusheng's change anyway :)

Eoghan Glynn (eglynn)
Changed in ceilometer:
assignee: Liusheng (liusheng) → Lena Novokshonova (enovokshonova)
Revision history for this message
Liusheng (liusheng) wrote :

Hi Dina Belova, Eoghan, I'm so sorry for my fault. Lena, could please fix this issue ASAP?

Revision history for this message
Lena Novokshonova (enovokshonova) wrote :

Hi Liusheng! I'm trying to understand and fix it now :)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/143092

Changed in ceilometer:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/143092
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=2518c6e97d744a34d268684e45f4371e416f4f2a
Submitter: Jenkins
Branch: master

commit 2518c6e97d744a34d268684e45f4371e416f4f2a
Author: Lena Novokshonova <email address hidden>
Date: Fri Dec 19 16:44:53 2014 +0400

    Check to skip to poll and publish when no resource

    This fix checks if pollster must have resources or not.
    Currently only ipmi pollsters do not require resources.

    Change-Id: I8e047acbc3c55184dcac99f8e73e3060ecd02507
    Closes-bug: 1403505

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.