neutron

Cisco cfg_agent: unsupported format character in logging string

Bug #1403304 reported by Angus Lees
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Angus Lees
neutron 2015.1.0 "kilo"

Bug Description

CiscoCfgAgent.hosting_devices_removed() contains an error in the
format string used to log errors:

    LOG.error(_LE("Invalid payload format for received RPC message "
  "`hosting_devices_removed`. Error is %{error}s. "
  "Payload is %(payload)s"),
       {'error': e, 'payload': payload})

"%{error}s" should be "%(error)s"

The existing version raises "ValueError: unsupported format character
'{' (0x7b)" when invoked.

(found via pylint)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/142342

Changed in neutron:
assignee: nobody → Angus Lees (gus)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/142342
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a1a908e815f27f630bc7a7a5dfc06031cfc2bf3b
Submitter: Jenkins
Branch: master

commit a1a908e815f27f630bc7a7a5dfc06031cfc2bf3b
Author: Angus Lees <email address hidden>
Date: Wed Dec 17 15:44:12 2014 +1100

    Cisco: unsupported format character in log format

    CiscoCfgAgent.hosting_devices_removed() contains an error in the
    format string used to log errors:

        LOG.error(_LE("Invalid payload format for received RPC message "
      "`hosting_devices_removed`. Error is %{error}s. "
      "Payload is %(payload)s"),
           {'error': e, 'payload': payload})

    "%{error}s" should be "%(error)s"

    The existing version raises "ValueError: unsupported format character
    '{' (0x7b)" when invoked.

    (found via pylint)

    Change-Id: Ic5e9db2a19aa7652cbbd1ee04d7e02914e8d0093
    Closes-Bug: #1403304

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.