ERR: sysctl -w net.bridge.bridge-nf-call-arptables="1" returned 255 instead of one of [0]

Fix proposed to branch: master
Review: https://review.openstack.org/140697

Fix proposed to branch: stable/5.1
Review: https://review.openstack.org/140698

Fix proposed to branch: stable/6.0
Review: https://review.openstack.org/140699

It looks like libvirtl service can't load 'bridge' kernel module in time before sysctl::vlaue puppet resource tries to execute 'sysctl -w' commands. Which is fine, since it still sets correct values in /etc/sysctl.conf and bridge module sets those keys to '1' itself. So this bug does not break or affect deployment, it just generates those error message in the puppet log. Although it's absolutely safe to ignore those error message from puppet, we still can avoid them if we simply update /etc/sysctl.conf and let 'bridge' module to handle runtime sysctl keys. I've committed appropriate patches to stable/5.1, stable/6.0 and master branches already.

Reviewed: https://review.openstack.org/140697
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=231b61ae14786211b5773959f95e6fbddecb3e27
Submitter: Jenkins
Branch: master

commit 231b61ae14786211b5773959f95e6fbddecb3e27
Author: Aleksandr Didenko <email address hidden>
Date: Wed Dec 10 16:32:08 2014 +0200

    Use augeas instead of sysctl::value

    We don't actually need to execute 'sysctl -w' for
    net.bridge.bridge-nf-call* sysctl keys since this can cause
    puppet errors if puppet tries to apply sysctl::value before bridge
    kernel module is loaded.

    So we just need to make sure those sysctl keys are configured
    properly in /etc/sysctl.conf file. When bridge kernel module is
    loaded by libvirt, it will set them to correct values itself.

    Closes-bug: #1401100
    Change-Id: Ib53038bc53846d14a6c7bf028c7b4e78eef56255

Reviewed: https://review.openstack.org/140699
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=b9cbfd233520e7f94ec35b018b4f2b799fa8dee7
Submitter: Jenkins
Branch: stable/6.0

commit b9cbfd233520e7f94ec35b018b4f2b799fa8dee7
Author: Aleksandr Didenko <email address hidden>
Date: Wed Dec 10 16:32:08 2014 +0200

    Use augeas instead of sysctl::value

    We don't actually need to execute 'sysctl -w' for
    net.bridge.bridge-nf-call* sysctl keys since this can cause
    puppet errors if puppet tries to apply sysctl::value before bridge
    kernel module is loaded.

    So we just need to make sure those sysctl keys are configured
    properly in /etc/sysctl.conf file. When bridge kernel module is
    loaded by libvirt, it will set them to correct values itself.

    Closes-bug: #1401100
    Change-Id: Ib53038bc53846d14a6c7bf028c7b4e78eef56255

Reviewed: https://review.openstack.org/140698
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=44968069b64314dc3687986272273c0c15df2570
Submitter: Jenkins
Branch: stable/5.1

commit 44968069b64314dc3687986272273c0c15df2570
Author: Aleksandr Didenko <email address hidden>
Date: Wed Dec 10 16:32:08 2014 +0200

    Use augeas instead of sysctl::value

    We don't actually need to execute 'sysctl -w' for
    net.bridge.bridge-nf-call* sysctl keys since this can cause
    puppet errors if puppet tries to apply sysctl::value before bridge
    kernel module is loaded.

    So we just need to make sure those sysctl keys are configured
    properly in /etc/sysctl.conf file. When bridge kernel module is
    loaded by libvirt, it will set them to correct values itself.

    Closes-bug: #1401100
    Change-Id: Ib53038bc53846d14a6c7bf028c7b4e78eef56255

Verified on ISO #56

"build_id": "2014-12-18_01-32-01", "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4", "build_number": "56", "auth_required": true, "api": "1.0", "nailgun_sha": "5f91157daa6798ff522ca9f6d34e7e135f150a90", "production": "docker", "fuelmain_sha": "45caacadb878abfbd9d60e134d72229698b469c9", "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91", "feature_groups": ["mirantis"], "release": "6.0", "release_versions": {"2014.2-6.0": {"VERSION": {"build_id": "2014-12-18_01-32-01", "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4", "build_number": "56", "api": "1.0", "nailgun_sha": "5f91157daa6798ff522ca9f6d34e7e135f150a90", "production": "docker", "fuelmain_sha": "45caacadb878abfbd9d60e134d72229698b469c9", "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91", "feature_groups": ["mirantis"], "release": "6.0", "fuellib_sha": "73332192a257ea02c40a39885c502ad1ebdf3eda"}}}, "fuellib_sha": "73332192a257ea02c40a39885c502ad1ebdf3eda"

Verified on ISO #58

"build_id": "2015-01-13_21-50-03", "ostf_sha": "0c1b663c6fc02ad972f2ed9ff6b000e7be1ea207", "build_number": "58", "auth_required": true, "api": "1.0", "nailgun_sha": "6fa6147384b533fb3d56cdc49ec6ecbcca47675d", "production": "docker", "fuelmain_sha": "", "astute_sha": "82125b0eef4e5a758fd4afa8917812e09a1f7dac", "feature_groups": ["mirantis"], "release": "6.1", "release_versions": {"2014.2-6.0": {"VERSION": {"build_id": "2015-01-13_21-50-03", "ostf_sha": "0c1b663c6fc02ad972f2ed9ff6b000e7be1ea207", "build_number": "58", "api": "1.0", "nailgun_sha": "6fa6147384b533fb3d56cdc49ec6ecbcca47675d", "production": "docker", "fuelmain_sha": "", "astute_sha": "82125b0eef4e5a758fd4afa8917812e09a1f7dac", "feature_groups": ["mirantis"], "release": "6.1", "fuellib_sha": "c53cb3a2bd5f99f32f78ed18e9472724fa6a9a9e"}}}, "fuellib_sha": "c53cb3a2bd5f99f32f78ed18e9472724fa6a9a9e"