Stop disabling external schemes via QDesktopServices in tests
Bug #1399330 reported by
Chris Coulson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Oxide |
Fix Released
|
Medium
|
Chris Coulson |
Bug Description
Some tests use a bogus protocol to trigger an error condition (ie, failed load). Since bug 1384460 landed, these bogus protocols get handed off to QDesktopServices which results in the load being cancelled. To work around this, there is a test API to tell QDesktopServices to not handle the bogus protocol, restoring the old behaviour (load failing).
Rather than doing this we should adapt the tests to accept the updated beahviour (which I assume is that we get a stopped load rather than a failed load), as this is closer to the real-world behaviour. Tests that need a failed load should create it another way (eg, using an invalid http URL)
Related branches
Changed in oxide: | |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in oxide: | |
assignee: | nobody → Chris Coulson (chrisccoulson) |
milestone: | none → branch-1.5 |
status: | Triaged → Fix Released |
To post a comment you must log in.