congress

restructure get_status api return

Bug #1399003 reported by Aaron Rosen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
congress
Fix Released
Undecided
Samta Rangare
congress kilo-3

Bug Description

currently the get datasource status returns data structured like this:

 {u'results': [{u'key': u'initialized', u'value': u'True'}, {u'key': u'last_error', u'value': u'None'}, {u'key': u'last_updated', u'value': u'2014-12-03 14:06:16.313310'}, {u'key': u'number_of_updates', u'value': u'52'}]}

Having the 'key', 'value' attributes here don't really add anything. Instead we should restructure the response to look like this:

 {u'results': [{ u'initialized': u'True', u'last_error': u'None', 'last_updated': u'2014-12-03 14:06:16.313310', 'number_of_updates': '52'}]}

Revision history for this message
Aaron Rosen (arosen) wrote :

https://github.com/stackforge/congress/blob/master/congress/api/status_model.py#L78

Fix needs to be made there.

tags: added: low-hanging-fruit
Samta Rangare (srangare)
Changed in congress:
assignee: nobody → Samta Rangare (srangare)
Abhishek Chanda (abhishek-i)
Changed in congress:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to congress (master)

Fix proposed to branch: master
Review: https://review.openstack.org/141658

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to congress (master)

Reviewed: https://review.openstack.org/141658
Committed: https://git.openstack.org/cgit/stackforge/congress/commit/?id=fbf368ce129fa789cf6edc105edc0d102d7204b7
Submitter: Jenkins
Branch: master

commit fbf368ce129fa789cf6edc105edc0d102d7204b7
Author: Samta Rangare <email address hidden>
Date: Sun Dec 14 23:28:47 2014 +0530

    restructure get_status api return

    This patch restructure the return of get_status api result.
    Existing test (test_status_api_mode) has been modified along
    with the temepst test coverage to verify new restructure.

    Change-Id: Ie2844c8cdd8900045a82e789c942c146c2221f48
    Closes-Bug: #1399003

Changed in congress:
status: In Progress → Fix Committed
Tim Hinrichs (thinrichs)
Changed in congress:
milestone: none → kilo-3
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.