DVR code can add duplicate routing rules
Bug #1398865 reported by
Brian Haley
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| neutron |
Fix Released
|
Medium
|
Brian Haley | ||
Bug Description
The IPRule code in ip_lib.py doesn't check if a rule already exists, so it could add a duplicate on agent restart. For example:
$ sudo ip netns exec qrouter-
0: from all lookup local
32766: from all lookup main
32767: from all lookup default
167772161: from 10.0.0.1/24 lookup 167772161
167772161: from 10.0.0.1/24 lookup 167772161
It should check first and not add anything if one is already there as there is no 'replace' option like the routing table has (which will either update or add).
DVR is currently the only consumer of this code.
| Changed in neutron: | |
| assignee: | nobody → Brian Haley (brian-haley) |
Revision history for this message
| huangyunpeng (huangyunpeng) wrote | #1 |
| Changed in neutron: | |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix proposed to neutron (master) | #2 |
| Changed in neutron: | |
| status: | Confirmed → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to neutron (master) | #3 |
| Changed in neutron: | |
| status: | In Progress → Fix Committed |
| Changed in neutron: | |
| milestone: | none → kilo-3 |
| status: | Fix Committed → Fix Released |
| Changed in neutron: | |
| milestone: | kilo-3 → 2015.1.0 |
To post a comment you must log in.
the input routes info is dict , it can be do same params check in neutron-server , I have did some fix in this bug , make the same routes info unacceptable in db.