congress

Enable: H305 imports not grouped correctly

Bug #1398551 reported by Aaron Rosen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
congress
Fix Released
Undecided
Samta Rangare
congress kilo-3

Bug Description

H305 imports not grouped correctly

https://review.openstack.org/#/c/135881/5 for example

Aaron Rosen (arosen)
summary: - H305 imports not grouped correctly
+ Enable: H305 imports not grouped correctly
Samta Rangare (srangare)
Changed in congress:
assignee: nobody → Samta Rangare (srangare)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to congress (master)

Fix proposed to branch: master
Review: https://review.openstack.org/139811

Changed in congress:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to congress (master)

Reviewed: https://review.openstack.org/139811
Committed: https://git.openstack.org/cgit/stackforge/congress/commit/?id=c4d66c1dfba2055aa936f7706583936a763dd6d7
Submitter: Jenkins
Branch: master

commit c4d66c1dfba2055aa936f7706583936a763dd6d7
Author: Samta Rangare <email address hidden>
Date: Sat Dec 6 21:11:53 2014 +0530

    Enable: H305 imports not grouped correctly

    Change-Id: Idba7feb9eaf5d6734ad8176e79b83dbb8e733e9d
    Closes-Bug: #1398551

Changed in congress:
status: In Progress → Fix Committed
Revision history for this message
Janet Yu (jwy) wrote :

This bug fix is incomplete. H305 is still in the "ignore" list in tox.ini.

Revision history for this message
Janet Yu (jwy) wrote :

After I remove "H305" from the "ignore" list in tox.ini, running "tox -epep8", "run_tests.sh --pep8", or "flake8" inside the .tox or .venv virtualenv does not result in H305 errors getting reported. However, if I run "run_tests.sh -N --pep8" or "flake 8" outside the virtualenv, the H305 errors appear. The versions of python, pep8, hacking, flake8, and pyflakes are the same between the virtualenvs and locally. I spent some time trying to figure out the difference between the environments without any luck. Anyone have ideas on what to check?

Revision history for this message
Samta Rangare (srangare) wrote :

Not sure why but true that H305 wasnt enable in tox.ini . Now i am wondering how test got pass at jenkins.
No idea about this environment check.

Revision history for this message
Samta Rangare (srangare) wrote :

H305 is enable now.
https://review.openstack.org/#/c/143271/

Tim Hinrichs (thinrichs)
Changed in congress:
milestone: none → kilo-3
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.