Ceilometer

virt.inspector.inspect_instances is not used anywhere, we should remove it

Bug #1397485 reported by ZhiQiang Fan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Low
ZhiQiang Fan
Ceilometer 2015.1.0 "kilo"

Bug Description

we only has definition but doesn't use it at all

zqfan@aji:~/openstack/ceilometer$ grep inspect_instances ceilometer -r | grep -v 'pyc matches' | grep -v 'ceilometer/tests/'
1:1:ceilometer/compute/virt/inspector.py:150: def inspect_instances(self):
2:3:ceilometer/compute/virt/hyperv/inspector.py:36: def inspect_instances(self):
3:5:ceilometer/compute/virt/libvirt/inspector.py:120: def inspect_instances(self):
4:7:ceilometer/compute/virt/xenapi/inspector.py:114: def inspect_instances(self):

ZhiQiang Fan (aji-zqfan)
Changed in ceilometer:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/137874

Changed in ceilometer:
status: New → In Progress
Ildiko Vancsa (ildiko-vancsa)
Changed in ceilometer:
importance: Undecided → Low
Ildiko Vancsa (ildiko-vancsa)
Changed in ceilometer:
milestone: none → kilo-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/137874
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=2757977c33f8913ee2ff5756ae174baab5ad4dd7
Submitter: Jenkins
Branch: master

commit 2757977c33f8913ee2ff5756ae174baab5ad4dd7
Author: ZhiQiang Fan <email address hidden>
Date: Sat Nov 29 11:25:10 2014 +0800

    Remove inspect_instances method from virt

    compute.virt.inspector:Inspector.inspect_instances has been introduced
    on Dec 4, 2012, by commit 40a3874c3845ccb2756f92f48be6baae820ee90d,
    but not used at that time[1], and even for current code[2]. This patch
    removes those code and corresponding test code.

    1. https://launchpad.net/ceilometer/grizzly/grizzly-2/+download/ceilometer-2013.1%7Eg2.tar.gz
    2. $ grep inspect_instances ceilometer -r | grep -v 'pyc matches' | grep -v 'ceilometer/tests/'
    ceilometer/compute/virt/inspector.py:150: def inspect_instances(self):
    ceilometer/compute/virt/hyperv/inspector.py:36: def inspect_instances(self):
    ceilometer/compute/virt/libvirt/inspector.py:120: def inspect_instances(self):
    ceilometer/compute/virt/xenapi/inspector.py:114: def inspect_instances(self):

    Change-Id: I37c7b63e756fb9f92a4031b5c324702dd85b9fff
    Closes-Bug: #1397485

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.