[UbuntuShape] Colored shapes aren't batched together
Bug #1396165 reported by
Loïc Molinari
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Loïc Molinari | ||
Vivid |
New
|
Undecided
|
Unassigned |
Bug Description
The current UbuntuShape uses a uniform variable to communicate its color to the shading system. That prevents the Qt batched renderer to batch colored shapes together for efficient rendering. Storing the color as attributes in the vertex buffer would fix that.
Related branches
lp://staging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-shape-rewrite
- PS Jenkins bot: Approve (continuous-integration)
- Zsombor Egri: Approve
-
Diff: 3415 lines (+1965/-1054)13 files modified.bzrignore (+1/-0)
components.api (+40/-15)
examples/ubuntu-ui-toolkit-gallery/UbuntuShape.qml (+26/-23)
modules/Ubuntu/Components/Themes/Ambiance/ProgressBarStyle.qml (+1/-1)
modules/Ubuntu/Components/plugin/plugin.cpp (+6/-5)
modules/Ubuntu/Components/plugin/plugin.pro (+10/-3)
modules/Ubuntu/Components/plugin/plugin.qrc (+6/-0)
modules/Ubuntu/Components/plugin/shaders/shape.frag (+57/-0)
modules/Ubuntu/Components/plugin/shaders/shape.vert (+43/-0)
modules/Ubuntu/Components/plugin/ucubuntushape.cpp (+1202/-820)
modules/Ubuntu/Components/plugin/ucubuntushape.h (+270/-183)
modules/Ubuntu/Components/plugin/ucubuntushapetexture.h (+4/-4)
tests/resources/ubuntushape/UbuntuShapeTest.qml (+299/-0)
To post a comment you must log in.
This bug was fixed in the package ubuntu-ui-toolkit - 1.2.1433+ 15.04.20150306- 0ubuntu1
--------------- 15.04.20150306- 0ubuntu1) vivid; urgency=medium
ubuntu-ui-toolkit (1.2.1433+
[ Albert Astals Cid ] text_longtap_ when_active under opengles2. itemselector. qml to EXCEPTIONS. So warnings are header. qml and fix vate::write( ) ttached and UCActionPanel classes removed. SERVICEPROPERTI ES_WARNINGS environment variable set will
* Fix infinite icon size grow when asked for a non square icon
Fixes: LP: #1422835
* IconProvider: Make sure icons fit in the given size
[ Christian Dywan ]
* Skip select_
Fixes: LP: #1401140
* Support for multiple devices with push_to_phone.sh.
* Take OrientationHelper y coordinate from real parent height.
Fixes: LP: #1413194
* Update popover position upon pointer movement.
Fixes: LP: #1199502, LP: #1415532
* Change <code> to be inline-block. Fixes LP: #1427534
* Set right anchor on tab overflow buttons. Fixes LP: #1425433
* Add tst_listitems_
no longer fatal for unit test.
[ Sebastien Bacher ]
* document that MainView's applicationName is used to set the gettext
domain. Fixes: LP: #1421661.
[ Tiago Salem Herrmann ]
* Drop cache once properties are successfully restored.
[ Timo Jyrinki ]
* Add dist-upgrade option to the UITK Test Plan script. Output the
selected parameters in the beginning.
[ Tim Peeters ]
* Add MainView 1.2 which removes the deprecated toolbar support.
* Enable PageStack header animations for MainView 1.2.
* Fix the size and anchors of a Page that is loaded inside a Loader.
This is useful when a Page is Loaded by a Tab. Fixes: LP: #1424635
* Fix UITK gallery content page width.
Fixes: LP: #1424635, LP: #1425470
* Set objectName for MainView int est_textinput.
scenarios in test_textinput.py
[ Zsombor Egri ]
* Alarm services regression fix. Fixes: LP: #1401883
* Implement ListItem dragging support in ListView.
Fixes: LP: #119535
* Introducing select/multiselect mode in ListItem.
* Moving the tst_focus.qml under exceptions till we fix DatePicker
binding loops.
* RTL (Right To Left) support in ListItem.
* RTM branch diff merge. Fixes: LP: #1358610.
* Second stage of simplification - divider group property is an item,
simplifying the anchoring of the contentItem. PropertyChange does
not backup the property binding, uses QQmlPropertyPri
with parameter to keep bindings. ListItemAnimator uses behavior to
animate snapping. Styling got "styledItem" context property to obey
general styling rules. clicked() and pressAndHold() emission fix
when content is swiped.
* Transferring the ListItem attached properties to ListItemStyle API.
Most of the style API became redundant, and removed. Few API from
ListItem were also removed as not needed. ListItemAnimator,
UCListItemA
Panel swiping overshoot made elastic. Snapping animation transformed
into SmoothedAnimation, uses velocity of 60GU/second. Turning
warnings to be reported in the error property.
SHOW_
display them in the console. Fixes: LP: #1423203.
* Updating documentation and imports for 1.2 & Vivid (Qt 5.4).
...