OpenStack Identity (keystone)

Memcache distributed lock ruins HA

Bug #1395688 reported by Alexander Makarov
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Alexander Makarov
OpenStack Identity (keystone) 2015.1.0 "kilo"
Juno
Fix Released
Medium
Eric Brown
OpenStack Identity (keystone) 2014.2.3

Bug Description

Current memcache lock's polling interval calculation locks execution for too long.
In concurrent environment when distributed locking is actively used the chance of 8 subsequent lock collisions is high enough to begin failing authorisation due to timeout.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/136749

Changed in keystone:
assignee: nobody → Alexander Makarov (amakarov)
status: New → In Progress
Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/136749
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=ee93b64af4f64e8e7b903e70d44eb021ab97c9ef
Submitter: Jenkins
Branch: master

commit ee93b64af4f64e8e7b903e70d44eb021ab97c9ef
Author: Alexander Makarov <email address hidden>
Date: Mon Nov 24 16:05:40 2014 +0300

    Speed up memcache lock

    Simplify sleep timeouts calculation removing progressive scale.

    Closes-bug: #1395688
    Change-Id: I0f1b620df9631a4b081e8c0be93d8a9b2d60e105

Changed in keystone:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (feature/hierarchical-multitenancy)

Fix proposed to branch: feature/hierarchical-multitenancy
Review: https://review.openstack.org/138182

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (feature/hierarchical-multitenancy)

Change abandoned by Morgan Fainberg (<email address hidden>) on branch: feature/hierarchical-multitenancy
Review: https://review.openstack.org/138182

Morgan Fainberg (mdrnstm)
Changed in keystone:
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/166496

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (stable/juno)

Reviewed: https://review.openstack.org/166496
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=e3cfba873bf02c4d26e2e1a275b9412b7eb54fa0
Submitter: Jenkins
Branch: stable/juno

commit e3cfba873bf02c4d26e2e1a275b9412b7eb54fa0
Author: Alexander Makarov <email address hidden>
Date: Mon Nov 24 16:05:40 2014 +0300

    Speed up memcache lock

    Simplify sleep timeouts calculation removing progressive scale.

    Closes-bug: #1395688
    Change-Id: I0f1b620df9631a4b081e8c0be93d8a9b2d60e105
    (cherry picked from commit ee93b64af4f64e8e7b903e70d44eb021ab97c9ef)

tags: added: in-stable-juno
Thierry Carrez (ttx)
Changed in keystone:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.