acceptance_tests are too chatty
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Medium
|
Cemil Azizoglu | ||
| mir (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
acceptance tests have started becoming obfuscated with messages that are not related to what is being tested:
eg:
[----------] 3 tests from ServerSignal
[ RUN ] ServerSignal.
[1416406602.185984] (II) UnknownComponent: Starting Mir server
[1416406602.200318] (II) UnknownComponent: Stopping Mir Server
[1416406602.204740] (II) UnknownComponent: Stopping Mir Server
[ OK ] ServerSignal.
[ RUN ] ServerSignal.
[1416406602.207911] (II) UnknownComponent: Starting Mir server
[1416406602.221617] (II) UnknownComponent: Stopping Mir Server
[1416406602.226197] (II) UnknownComponent: Stopping Mir Server
[ OK ] ServerSignal.
[ RUN ] ServerSignal.
[1416406602.229390] (II) UnknownComponent: Starting Mir server
[ OK ] ServerSignal.
[----------] 3 tests from ServerSignal (242 ms total)
Related branches
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Alan Griffiths: Needs Fixing
- Alexandros Frantzis (community): Needs Fixing
-
Diff: 143 lines (+35/-5)8 files modifiedinclude/platform/mir/options/configuration.h (+1/-0)
src/common/logging/logger.cpp (+1/-2)
src/include/common/mir/logging/logger.h (+8/-0)
src/platform/options/default_configuration.cpp (+4/-2)
src/platform/symbols.map (+1/-0)
src/server/default_server_configuration.cpp (+4/-1)
tests/mir_test_framework/CMakeLists.txt (+6/-0)
tests/mir_test_framework/headless_test.cpp (+10/-0)
- PS Jenkins bot (community): Approve (continuous-integration)
- Cemil Azizoglu (community): Approve
-
Diff: 176 lines (+96/-0)6 files modifiedtests/include/mir_test_doubles/null_logger.h (+42/-0)
tests/include/mir_test_framework/stubbed_server_configuration.h (+1/-0)
tests/mir_test_doubles/CMakeLists.txt (+1/-0)
tests/mir_test_doubles/null_logger.cpp (+28/-0)
tests/mir_test_framework/headless_test.cpp (+13/-0)
tests/mir_test_framework/stubbed_server_configuration.cpp (+11/-0)
| summary: |
- tests are too chatty + acceptance_tests are too chatty |
| Changed in mir: | |
| status: | New → Confirmed |
| Changed in mir: | |
| assignee: | nobody → Cemil Azizoglu (cemil-azizoglu) |
| Daniel van Vugt (vanvugt) wrote | #1 |
| Alan Griffiths (alan-griffiths) wrote | #2 |
| Changed in mir: | |
| milestone: | none → 0.10.0 |
| status: | Confirmed → In Progress |
| PS Jenkins bot (ps-jenkins) wrote | #3 |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
| Daniel van Vugt (vanvugt) wrote | #4 |
| Changed in mir (Ubuntu): | |
| importance: | Undecided → Medium |
| status: | New → Fix Released |
Seems we just need to remember to assign a NullLogger to the test server.