Unconfig_storage is not removing storage-stats daemon

Bug #1392434 reported by Vinod Nair
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Fix Committed
High
Shreya Kunjir
R1.1
Fix Committed
High
Shreya Kunjir
R2.0
Fix Committed
High
Shreya Kunjir

Bug Description

un-Configure storage is not removing the stats daemon . We should be removing all storage related
processes / configs

ps -ef | grep stats
root 3162 18587 0 09:57 pts/8 00:00:00 grep --color=auto stats
root 26745 1 1 01:50 ? 00:05:01 /usr/bin/python /usr/bin/contrail-storage-stats --conf_file /etc/contrail/contrail-storage-nodemgr.conf

Version Ubuntu -Havana 1.21 - HA

Tags: storage
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/4621
Committed: http://github.org/Juniper/contrail-fabric-utils/commit/01f1b235050c87ddd20fff41705738b88f6ac184
Submitter: Zuul
Branch: R1.10

commit 01f1b235050c87ddd20fff41705738b88f6ac184
Author: shreya12 <email address hidden>
Date: Sat Nov 15 11:15:30 2014 -0800

Closes-Bug: #1391346
Closes-Bug: #1392434
Issue: 1. contrail-storage-stats is getting started on
non storage-compute nodes
2. cleanup of contrail-storage-stats not done
during storage unconfigure
Fix: 1. contrail-storage-stats started only on storage-compute
nodes.
2. During uncongiure, if the storage-stats daemon running
then it is terminated and reset config to defaults
Test: Verified the changes in both HA and non-HA setups

Modified according to review-1
1. If Contrail vip (openstack and contrail on separate nodes)
configured use that for contrail stats else openstack vip
(openstack and contrail together case)configured use that
else config host discovery address
2. Contrail vip value passed from fab utils to provision
setup (Saravanan change)

Change-Id: I76ffc0573661b9dc7c5fdc200aa4d447dbdd1f99

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/4577
Committed: http://github.org/Juniper/contrail-provisioning/commit/f4ec5736d6821e3c310716301fab4e6bb90d7cd8
Submitter: Zuul
Branch: R1.10

commit f4ec5736d6821e3c310716301fab4e6bb90d7cd8
Author: shreya12 <email address hidden>
Date: Thu Nov 13 14:58:01 2014 -0800

Closes-Bug: #1391346
Closes-Bug: #1392434
Issue: 1. contrail-storage-stats is getting started on
non storage-compute nodes
2. cleanup of contrail-storage-stats not done
during storage unconfigure
Fix: 1. contrail-storage-stats started only on storage-compute
nodes.
2. During uncongiure, if the storage-stats daemon running
then it is terminated and reset config to defaults
Test: Verified the changes in both HA and non-HA setups

Modified according to review-1
1. If Contrail vip (openstack and contrail on separate nodes)
configured use that for contrail stats else openstack vip
(openstack and contrail together case)configured use that
else config host discovery address
2. Contrail vip value passed from fab utils to provision
setup (Saravanan change)

Change-Id: I260c631da9c9d7e002d8a90bbd56839bdffc3d3d

information type: Proprietary → Public
Changed in juniperopenstack:
assignee: nobody → Shreya Kunjir (shreyak-9)
Changed in juniperopenstack:
status: New → Fix Committed
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/5094
Committed: http://github.org/Juniper/contrail-provisioning/commit/5620c40220bcc85ba4cdbaead08182a2c61f5ebb
Submitter: Zuul
Branch: master

commit 5620c40220bcc85ba4cdbaead08182a2c61f5ebb
Author: shreya12 <email address hidden>
Date: Mon Dec 1 15:12:56 2014 -0800

Closes-Bug: #1392434
-Issue: 1. contrail-storage-stats is getting started on
non storage-compute nodes
2. cleanup of contrail-storage-stats not done
during storage unconfigure
-Fix: 1. contrail-storage-stats started only on storage-compute
nodes.
2. During uncongiure, if the storage-stats daemon running
then it is terminated and reset config to defaults
-Test: Verified the changes in both HA and non-HA setups

Modified according to review-1
Modified according to review-2
1. If Contrail vip (openstack and contrail on separate nodes)
configured use that for contrail stats else openstack vip
(openstack and contrail together case)configured use that
else config host discovery address
2. Contrail vip value passed from fab utils to provision
setup (Saravanan change)

Change-Id: Iec9aa6981ceec76bcde74d147cf235147dcf96f9

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/5095
Committed: http://github.org/Juniper/contrail-fabric-utils/commit/2d8b7d7f1c0cec8df73b20150dfbfb20410bd627
Submitter: Zuul
Branch: master

commit 2d8b7d7f1c0cec8df73b20150dfbfb20410bd627
Author: shreya12 <email address hidden>
Date: Mon Dec 1 15:20:09 2014 -0800

Closes-Bug: #1392434
-Issue: 1. contrail-storage-stats is getting started on
non storage-compute nodes
2. cleanup of contrail-storage-stats not done
during storage unconfigure
-Fix: 1. contrail-storage-stats started only on storage-compute
nodes.
2. During uncongiure, if the storage-stats daemon running
then it is terminated and reset config to defaults
-Test: Verified the changes in both HA and non-HA setups

Modified according to review-1
Modified according to review-2
1. If Contrail vip (openstack and contrail on separate nodes)
configured use that for contrail stats else openstack vip
(openstack and contrail together case)configured use that
else config host discovery address
2. Contrail vip value passed from fab utils to provision
setup (Saravanan change)

Change-Id: I1270be40a5d030aaf58c2c423c72ee777f79cfb7

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/5224
Committed: http://github.org/Juniper/contrail-provisioning/commit/abf1975122ff86a4bd3155402fe42ee5dcea605c
Submitter: Zuul
Branch: R2.0

commit abf1975122ff86a4bd3155402fe42ee5dcea605c
Author: shreya12 <email address hidden>
Date: Wed Dec 3 11:11:18 2014 -0800

Closes-Bug: #1392434
-Issue: 1. contrail-storage-stats is getting started on
non storage-compute nodes
2. cleanup of contrail-storage-stats not done
during storage unconfigure
-Fix: 1. contrail-storage-stats started only on storage-compute
nodes.
2. During uncongiure, if the storage-stats daemon running
then it is terminated and reset config to defaults
-Test: Verified the changes in both HA and non-HA setups

Modified according to review-1
Modified according to review-2
1. If Contrail vip (openstack and contrail on separate nodes)
configured use that for contrail stats else openstack vip
(openstack and contrail together case)configured use that
else config host discovery address
2. Contrail vip value passed from fab utils to provision
setup (Saravanan change)

Change-Id: I7b6e65b71f91501bc40f6e35e116943a16bf0623

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/5285
Committed: http://github.org/Juniper/contrail-fabric-utils/commit/e1fb600144e82e6e92f05a1283782c46347c0345
Submitter: Zuul
Branch: R2.0

commit e1fb600144e82e6e92f05a1283782c46347c0345
Author: shreya12 <email address hidden>
Date: Thu Dec 4 11:57:30 2014 -0800

Closes-Bug: #1392434
-Issue: 1. contrail-storage-stats is getting started on
non storage-compute nodes
2. cleanup of contrail-storage-stats not done
during storage unconfigure
-Fix: 1. contrail-storage-stats started only on storage-compute
nodes.
2. During uncongiure, if the storage-stats daemon running
then it is terminated and reset config to defaults
-Test: Verified the changes in both HA and non-HA setups

Modified according to review-1
Modified according to review-2

1. If Contrail vip (openstack and contrail on separate nodes)
configured use that for contrail stats else openstack vip
(openstack and contrail together case)configured use that
else config host discovery address
2. Contrail vip value passed from fab utils to provision
setup (Saravanan change)

Change-Id: I0da03f17713dc4753c03b48935a803fd10fa730f

Revision history for this message
Vinod Nair (vinodnair) wrote :

Even though after provisioning the stats daemon was not running on the storage master , after rebooting the storage master it started running

contrail-status | grep storage
contrail-storage-stats: active
root@cs-scale-1:~# ps -ef | grep storage
root 2175 1 0 20:28 ? 00:00:01 /usr/bin/python /usr/bin/contrail-storage-stats --conf_file /etc/contrail/contrail-storage-nodemgr.conf
root 8806 27732 0 20:37 pts/2 00:00:00 grep --color=auto storage

Version : 2.0 build 12

ii cassandra 1.2.11 distributed storage system for structured data
ii ceph 0.80.4-2-g88f694d-1precise distributed storage and file system
ii ceph-common 0.80.4-2-g88f694d-1precise common utilities to mount and interact with a ceph storage cluster
ii cinder-api 1:2014.1.3-0ubuntu1~cloud0 Cinder storage service - API server
ii cinder-common 1:2014.1.3-0ubuntu1~cloud0 Cinder storage service - common files
ii cinder-scheduler 1:2014.1.3-0ubuntu1~cloud0 Cinder storage service - Scheduler server
ii cinder-volume 1:2014.1.3-0ubuntu1~cloud0 Cinder storage service - Volume server
ii contrail-storage 2.0-12 Contrail storage package
ii contrail-storage-packages 2.0-12~icehouse Contrail Storage Packages - Container of debian packages
ii contrail-web-storage 2.0-12 Contrail Storage Systems Web UI Feature
ii smartmontools 5.41+svn3365-1 control and monitor storage systems using S.M.A.R.T.

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/5558
Committed: http://github.org/Juniper/contrail-provisioning/commit/013ca7cd2cdee8bf9f46b3176d1eb3caae8bca61
Submitter: Zuul
Branch: R2.0

commit 013ca7cd2cdee8bf9f46b3176d1eb3caae8bca61
Author: shreya12 <email address hidden>
Date: Thu Dec 11 13:08:59 2014 -0800

Closes-Bug: #1398252
Closes-Bug: #1392434
-Issue: 1. contrail-storage-stats not started if the node
is configured as both master and compute storage
2. storage-stats getting started on master node
on node reboots

-Fix: 1. storage compute list is passed to storage setup
2. contrail-storage-stats daemon configured/started
based on this storage compute list
3. Removed contrail storage stats init configs on
master nodes.

Change-Id: I8c11fc0beb973a30d3b62c8d61f88c4f4ae810d5
-Test: Verified the changes in both HA and non-HA setups

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/5783
Committed: http://github.org/Juniper/contrail-provisioning/commit/5d28ec4da7b8abc9c285abbfb62858d94560df30
Submitter: Zuul
Branch: master

commit 5d28ec4da7b8abc9c285abbfb62858d94560df30
Author: shreya12 <email address hidden>
Date: Thu Dec 18 12:46:02 2014 -0800

Closes-Bug: #1398252
Closes-Bug: #1392434
-Issue: 1. contrail-storage-stats not started if the node
is configured as both master and compute storage
2. storage-stats getting started on master node
on node reboots

-Fix: 1. storage compute list is passed to storage setup
2. contrail-storage-stats daemon configured/started
based on this storage compute list
3. Removed contrail storage stats init configs on
master nodes.

Change-Id: I90e7b2560584a6d3c05d24d50f014530291319a5
-Test: Verified the changes in both HA and non-HA setups

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.