OpenStack Core Infrastructure

Requirements check job doesn't check requirements correctly

Bug #1391905 reported by Oleksii Chuprykov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Core Infrastructure
Fix Committed
High
Oleksii Chuprykov
OpenStack Core Infrastructure juno

Bug Description

requirements check job checks project requirements(stable branch) with global-requirements(master)
for example: https://review.openstack.org/#/c/132762/

Oleksii Chuprykov (ochuprykov)
Changed in openstack-ci:
assignee: nobody → Oleksii Chuprykov (ochuprykov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to project-config (master)

Fix proposed to branch: master
Review: https://review.openstack.org/134247

Changed in openstack-ci:
status: New → In Progress
Revision history for this message
Jeremy Stanley (fungi) wrote :

Can you explain what led you to this conclusion? The "fix" you've proposed looks like a no-op.

Changed in openstack-ci:
status: In Progress → Incomplete
Revision history for this message
Oleksii Chuprykov (ochuprykov) wrote :

Please see the logs of my example. http://logs.openstack.org/62/132762/1/check/gate-oslo.db-requirements/64257dc/console.html

Revision history for this message
Jeremy Stanley (fungi) wrote :

Aha, I see the problem now. The script was written to operate on a shallow clone (--depth 1) which won't allow us to checkout arbitrary refs like we try to do a couple lines later, unfortunately the run_command() function blinds us to the underlying cause because it has no error handling at all and just assumes things always work.

Changed in openstack-ci:
status: Incomplete → In Progress
importance: Undecided → High
milestone: none → juno
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to project-config (master)

Reviewed: https://review.openstack.org/134247
Committed: https://git.openstack.org/cgit/openstack-infra/project-config/commit/?id=853bd1a554ab93595e364477ddc2376a0ac89371
Submitter: Jenkins
Branch: master

commit 853bd1a554ab93595e364477ddc2376a0ac89371
Author: Oleksii Chuprykov <email address hidden>
Date: Thu Nov 13 17:15:44 2014 +0200

    Check requirements correctly

    Requirements check job doesn't correctly work on stable branches
    of openstack projects

    Closes-Bug: #1391905

    Change-Id: Id470777bbc01dae4ceab713c243e691004afe74f

Changed in openstack-ci:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.