Scratch

Hide Terminal and Browser Preview when no files are open

Bug #1390895 reported by Artem Anufrij
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Scratch
Fix Released
Low
Artem Anufrij
Scratch 2.1

Bug Description

I think "Scratch" will looks cleaner, if all plugins in the bottom and right site will be hidden on welcome screen.

See original description

Related branches

lp://staging/~artem-anufrij/scratch/hide-plugins-on-welcome-screen
Robert Roth (community): Approve
Diff: 218 lines (+60/-41)
3 files modified
plugins/browser-preview/browser-preview.vala (+26/-16)
plugins/terminal/terminal.vala (+20/-19)
src/MainWindow.vala (+14/-6)
Revision history for this message
Danielle Foré (danrabbit) wrote :

Can you elaborate on what you mean? In the case of some plugins (like folder browser), the plugin actually offers a quick way to open files.

Changed in scratch:
status: New → Incomplete
Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

Or we can hidden only the terminal plug in on welcome screen.

(see screenshot). It looks a little bit overload.

Artem Anufrij (artem-anufrij)
description: updated
Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

I think that the "Terminal" and "Browser preview" plugins should be visible after opening a file.

Revision history for this message
Danielle Foré (danrabbit) wrote :

Yeah I can agree with that.

With the browser preview, it probably shouldn't be shown unless there is an open tab that is it previewing (so for example, you don't want it to close if you switch to editing a CSS or JS file).

With the terminal, I guess it's a bit more arguable, since you can do things that don't require a document to be open. Maybe we need a more intelligent interaction between the welcome and terminal in the future. But for now, it's probably acceptable to just hide it.

summary: - Hide all plugins on welcome screen.
+ Hide Terminal and Browser Preview when no files are open
Changed in scratch:
status: Incomplete → Confirmed
Artem Anufrij (artem-anufrij)
Changed in scratch:
assignee: nobody → Artem Anufrij (artem-anufrij)
status: Confirmed → In Progress
Danielle Foré (danrabbit)
Changed in scratch:
importance: Undecided → Low
Artem Anufrij (artem-anufrij)
Changed in scratch:
status: In Progress → Fix Committed
milestone: none → freya-beta2
Danielle Foré (danrabbit)
Changed in scratch:
status: Fix Committed → Fix Released
Cody Garver (codygarver)
Changed in scratch:
milestone: freya-beta2 → 2.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.