Juniper Openstack

Fab: detect_ostype() uses uname, can this be changed to use platform.linux_distribution()

Bug #1390303 reported by Senthilnathan Murugappan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Released
Low
Senthilnathan Murugappan
Juniper Openstack r2.0-fcs

Bug Description

detect_ostype() looks at uname -a for specific keywords and determines the os type which doesnt work always.
Would it be better to change it to use platform.linux_distribution() which i hope gives ample info about the dist and release.

>>> platform.linux_distribution()
('Ubuntu', '14.04', 'trusty')
>>> platform.linux_distribution()
('CentOS', '6.5', 'Final')

Tags: provisioning
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/4361
Committed: http://github.org/Juniper/contrail-fabric-utils/commit/86dd41699752384cb4d28b81b43a2b64b520862d
Submitter: Zuul
Branch: master

commit 86dd41699752384cb4d28b81b43a2b64b520862d
Author: msenthil <email address hidden>
Date: Thu Nov 6 23:41:24 2014 -0800

Changing detecting linux distribution type based on 'uname -a' to platform.linux_distribution() call
Changed all references of dist string from 'Ubuntu' to 'ubuntu' for uniformity with other distribution references.
Closes-Bug: #1390303

Change-Id: I1eb6ef868b8986a02e80ac89bf2e98b1d761d8db

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.