juju-core

ppc64el unittests consistently fails

Bug #1388853 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
Critical
Menno Finlay-Smits
juju-core 1.21-alpha3

Bug Description

ppc64el unittests were moved back to stilson-08 per the advice of engineers because it had the gcc versions that matched the last pass of the unit tests. The tests still fail, but these are new failures that were not seen when we ran on stilson-08
    TestUpgradeStepsFailure.pN43_github_com_juju_juju_cmd_jujud.UpgradeSuite
    TestUpgradeStepsStateServer.pN43_github_com_juju_juju_cmd_jujud.UpgradeSuite
    TestSyncToolsFakeSeries.pN51_github_com_juju_juju_environs_sync_test.uploadSuite
    TestUploadFakeSeries.pN51_github_com_juju_juju_environs_sync_test.uploadSuite

The last pass of the test suite on this machine is October 29
    Revision build: 1980 gitbranch:master:github.com/juju/juju f2292c20
Several fixes were made to the tests, but this new issue remained and was not caused by a change in the machine the tests were run.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Attached is a log of the common failures.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Trying to attach again.

Revision history for this message
Martin Packman (gz) wrote :

Two separate kinds of failures.

First the sync_test.uploadSuite failures:

$ (cd environs/sync&&go test -compiler=gccgo)

sync_test.go:303:
    c.Assert(list, gc.HasLen, 3)
... obtained tools.List = tools.List{(*tools.Tools)(0xc215a5dd00), (*tools.Tools)(0xc215a5dd80), (*tools.Tools)(0xc215a5de00), (*tools.Tools)(0xc215a5de80), (*tools.Tools)(0xc215a5df00), (*tools.Tools)(0xc215a5df80)} ("1.21-alpha3-precise-ppc64el;1.21-alpha3-precise-ppc64;1.21-alpha3-quantal-ppc64el;1.21-alpha3-quantal-ppc64;1.21-alpha3-trusty-ppc64el;1.21-alpha3-trusty-ppc64")
... n int = 3

Note that there are tools listed for both "ppc64" and "ppc64el" - I think these tests just need updating given the changes from bug 1388493.

Second, the jujud.UpgradeSuite tests seem to just be flakey, probably related to machine speed in some fashion. We probably don't want to try and address that here.

In other runs, we also have speed related test failures:

<http://juju-ci.vapour.ws:8080/job/run-unit-tests-trusty-ppc64el/1805/console>

FAIL: user_test.go:85: TestUserList.pN39_github_com_juju_juju_cmd_juju.UserSuite
...
user_test.go:93:
    c.Assert(testing.Stdout(ctx), gc.Equals, expected)
... obtained string = "" +
... "NAME DISPLAY NAME DATE CREATED LAST CONNECTION\n" +
... "dummy-admin dummy-admin 2 seconds ago just now\n" +
... "\n"
... expected string = "" +
... "NAME DISPLAY NAME DATE CREATED LAST CONNECTION\n" +
... "dummy-admin dummy-admin just now just now\n" +
... "\n"

Wall clock dependent tests are not good tests, I don't think anyone really needs reminding...

Menno Finlay-Smits (menno.smits)
Changed in juju-core:
status: Triaged → In Progress
assignee: nobody → Menno Smits (menno.smits)
Ian Booth (wallyworld)
Changed in juju-core:
status: In Progress → Fix Committed
Revision history for this message
Curtis Hovey (sinzui) wrote :

The bug is not completly fixed :( Two error still remain
    FAIL: sync_test.go:270: TestSyncToolsFakeSeries.pN51_github_com_juju_juju_environs_sync_test.uploadSuite
    FAIL: sync_test.go:238: TestUploadFakeSeries.pN51_github_com_juju_juju_environs_sync_test.uploadSuite

I am attaching the log of the recent failures

Changed in juju-core:
status: Fix Committed → In Progress
Revision history for this message
Ian Booth (wallyworld) wrote :

The revision in the attached log wasn't the commit that fixed that part of this bug
3cb5b22467778c114621f0c8fe8a753ea9392fa8

The revision that fixes this bug is yet to go through CI: 9b341be3118465df225762c993c6e9d12cb8026f

Sadly the bug contained 2 issues and different developers worked on each single issue, each doing their own commits.

Changed in juju-core:
status: In Progress → Fix Committed
Revision history for this message
Ian Booth (wallyworld) wrote :

Opimistically perhaps marking back as Fix Committed

Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.