Parser files not checked into repo
Bug #1387209 reported by
Tim Hinrichs
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| congress |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
The 2 files we use to lex/parse policy strings are generated from a grammar by the makefile. These files are not checked into the repo, which is a reasonable thing to do since they are generated. Unfortunately, when the grammar changes, people need to remember to run 'make' in order to regenerate the lexer/parser. No one thinks to do this since the grammar changes very rarely and there is no other reason to run 'make' when pulling the latest from the repo. What happens is that the old lexer/parser continues to be used, and we get weird errors and behavior.
To fix this, I suggest we commit the generated files to the repo.
| Changed in congress: | |
| importance: | Undecided → Low |
| Changed in congress: | |
| status: | New → Confirmed |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to congress (master) | #1 |
| Changed in congress: | |
| status: | Confirmed → Fix Committed |
| Changed in congress: | |
| milestone: | none → kilo-3 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit d9a2789bf756502
Author: Tim Hinrichs <email address hidden>
Date: Tue Apr 14 16:57:41 2015 -0700
Add parser/lexer
These files are generated from congress/
but (i) they change rarely and so no one remembers to run
make and (ii) they require Java to generate. So it's
better for end-users and most developers to check the files in
and just have the people changing the grammar remember to
check in the generated files.
Closes-bug: 1387209
Change-Id: Ia315fc28570edf