deprecate meters that are really events

Bug #1384874 reported by gordon chung
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Wishlist
gordon chung

Bug Description

this is to discuss the value of certain 'meters'.

when having a quick look at measurements page we can see a bunch 'Existence of xyz' meters which don't actually measure anything.

for example:
instance
instance:<type>
network
subnet
port
router
ip.floating
image
volume
snapshot
<all keystone meters>
<all heat meters>
<all sahara meters>
switch
switch.port
network.services.lb.pool
network.services.lb.vip
network.services.member
network.services.health_monitor
<all VPNaaS meters>
<all FWaaS meters>
... probably a few others

tbh, i don't think these are meters and they only exists because the concept of events wasn't fully fleshed out. now that we support events in all backends, i think we should remove these 'meters' and make them events as they aren't measuring anything. also, it's confusing users as Horizon for quite some time thought that the meter volume actually represented something useful.

in most cases, this can be easily achieved as they are derived from real event notifications and we just need to add them to event definition file.... in some cases, they are polled so we need a way to translate them into events.

Revision history for this message
Liusheng (liusheng) wrote :

Hi gordon chung, thanks for this report, is there any discussion about this issue? or do you have any plan to drom this meters (maybe need a blueprint )? if this is approved, what the scope of meter should be droped? (most meters from notification-agent are really events). I agree with you, actually there is a known bug that the *instance* meter from notification you mentioned above will affect the *instance* samples from polling agent, that may will affect alarm (created by users) base on the number of instance. maybe the bug 1383751 and bug 1386178 will should be marked "invalid" :)

Revision history for this message
Liusheng (liusheng) wrote :
Revision history for this message
gordon chung (chungg) wrote :

@Liusheng, glad to hear you agree with me :). this is mostly for discussion whether or not this is acceptable to everyone (or majority). if it is, i will write up a blueprint to discuss the scope.

i think some issues we would need to address is:
1. what to do with existing 'meters' in metering db? do we write a script to migrate them to events?
2. how do we let users continue to record them as events? do we edit event_definition file to support these 'meter' event? and what traits do we decide to capture?
3. what do we do about alarming? i would think we would still need to do alarming on events.
... anything else?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/135709

Changed in ceilometer:
assignee: nobody → gordon chung (chungg)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/135720

gordon chung (chungg)
summary: - drop meters that are really events
+ deprecate meters that are really events
gordon chung (chungg)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/135709
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=54548f07b2c51d0f5e0e91236e269a5db1d90bbe
Submitter: Jenkins
Branch: master

commit 54548f07b2c51d0f5e0e91236e269a5db1d90bbe
Author: gordon chung <email address hidden>
Date: Wed Nov 19 15:06:48 2014 -0500

    add keystone events to definitions

    keystone events are not measurements and do not make much sense as
    samples. this patch adds definition for keystone events.

    Change-Id: I13b76a71cf434512190615266948293df4d34589
    Partial-Bug: #1384874

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/135720
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=cb3b96233a83686335b2a33b39b9ae9b5ea92c47
Submitter: Jenkins
Branch: master

commit cb3b96233a83686335b2a33b39b9ae9b5ea92c47
Author: gordon chung <email address hidden>
Date: Wed Nov 19 16:15:04 2014 -0500

    add sahara and heat events

    sahara and heat samples are not measurements. they also make no
    sense in the context of samples. this patch adds them to definitions
    file

    Change-Id: Ie19cc60897129bc012a8da1b068e309fd6120c7f
    Partial-Bug: #1384874

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/139823

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/141916

Revision history for this message
Lianhao Lu (lianhao-lu) wrote :

One question, if we deprecated those meters, can the ceilometer alarm be triggered by the events?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/139823
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=39d51579d43254e6915a5d5dbc22dbb79e716024
Submitter: Jenkins
Branch: master

commit 39d51579d43254e6915a5d5dbc22dbb79e716024
Author: gordon chung <email address hidden>
Date: Sat Dec 6 13:40:28 2014 -0500

    add cinder events

    there are a few 'existence of' meters in cinder that we could
    represent better as events. this patch adds them to the definition.

    Change-Id: I69dc1c3eb98b9821c4febb021656d0e9ca78af2e
    Partial-Bug: #1384874

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/141916
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=1191dc24a23f56e583f744946a8f69ec7e4bd6af
Submitter: Jenkins
Branch: master

commit 1191dc24a23f56e583f744946a8f69ec7e4bd6af
Author: gordon chung <email address hidden>
Date: Mon Dec 15 17:07:01 2014 -0500

    add glance events

    there are a few 'existence of' meters in glance that we could
    represent better as events. this patch adds them to the definition.

    Change-Id: I3d2ea24c37c2918c770d6ed4874f43d273f12953
    Partial-Bug: #1384874

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/156769

gordon chung (chungg)
Changed in ceilometer:
importance: Medium → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/156769
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=95463071ed095634d4277c7e04c601d00cb4311c
Submitter: Jenkins
Branch: master

commit 95463071ed095634d4277c7e04c601d00cb4311c
Author: gordon chung <email address hidden>
Date: Tue Feb 17 16:00:58 2015 -0500

    add network, kv-store, and http events

    this patch adds the remaining 'existence' meters we generate from
    notifications.

    Change-Id: I7695f4967944eee0d1e20acf3c9b9bc9c32a6a4a
    Partial-Bug: #1384874

Revision history for this message
gordon chung (chungg) wrote :
Changed in ceilometer:
status: In Progress → Fix Committed
gordon chung (chungg)
Changed in ceilometer:
milestone: none → liberty-rc1
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: liberty-rc1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.