config 'use_ipv6' = True doesn't work

Bug #1384509 reported by Ruby Loo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Ruby Loo

Bug Description

Ironic has a config 'use_ipv6' in ironic.netconf.py:

    cfg.BoolOpt('use_ipv6',
                default=False,
                help='Use IPv6.'),

but it isn't used, so it has no effect, and in fact, is misleading because someone may set it to True and think that it works :-(

There is a bug open for "Ironic should support IPv6".

In the meantime, I think we should remove the config.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/130409

Changed in ironic:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/130409
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=1a9d58115be7dfb6b79571d051f7b855229cc6cb
Submitter: Jenkins
Branch: master

commit 1a9d58115be7dfb6b79571d051f7b855229cc6cb
Author: Ruby Loo <email address hidden>
Date: Thu Oct 23 00:55:48 2014 +0000

    Delete unused 'use_ipv6' config option

    The 'use_ipv6' config option is not being used, and Ironic doesn't support
    IPv6 (see https://bugs.launchpad.net/ironic/+bug/1325942). Someone may
    try to set this value to True, and that wouldn't do anything, so it is
    better to delete it and add it back in the future when IPv6 is supported.

    I'm not sure it needs a DocImpact since it never worked, but I'll tag
    it, just in case we want to document that "the 'use_ipv6' config option
    was deleted because it never worked".

    Closes-Bug: #1384509
    DocImpact

    Change-Id: I7704067ca50448ffb0982e653437d151af85471f

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.