python-novaclient

inconsistent handling of endpoint_type setting

Bug #1382249 reported by Miguel Grinberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-novaclient
Fix Released
Undecided
Miguel Grinberg
python-novaclient 2.21.0

Bug Description

Two inconsistencies around the endpoint type:

1. Other clients (keystone, neutron, glance, etc) accept the endpoint_type connection setting in environment variable OS_ENDPOINT_TYPE. The nova client, however, uses a client specific variable called NOVA_ENDPOINT_TYPE. It would be good if novaclient checked the client agnostic variable if the nova specific one isn't set.

2. The command line argument in several other clients is --os-endpoint-type, while nova uses --endpoint-type. I think novaclient should accept either one.

See original description
Miguel Grinberg (miguelgrinberg)
Changed in python-novaclient:
assignee: nobody → Miguel Grinberg (miguelgrinberg)
Miguel Grinberg (miguelgrinberg)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/129357

Changed in python-novaclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/129357
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=607ac48e6c70e2d3be9a896d5db791f376a8a640
Submitter: Jenkins
Branch: master

commit 607ac48e6c70e2d3be9a896d5db791f376a8a640
Author: Miguel Grinberg <email address hidden>
Date: Fri Oct 17 19:03:23 2014 +0000

    support OS_ENDPOINT_TYPE in nova client

    This change makes the handling of the endpoint_type setting in the nova
    client more consistent while keeping backwards compatibility. The
    NOVA_ENDPOINT_TYPE environment variable is checked first, and if it is
    not set then the more generic OS_ENDPOINT_TYPE variable is checked. A
    --os-endpoint-type command line option was added as well.

    Change-Id: I0d96f9f87106fc41a9853920f557ffad724859e7
    Closes-Bug: 1382249

Changed in python-novaclient:
status: In Progress → Fix Committed
Michael Still (mikal)
Changed in python-novaclient:
milestone: none → 2.21.0
Michael Still (mikal)
Changed in python-novaclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.