getAreaExits is broken

Bug #1380822 reported by Vadim Peretokin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mudlet
Fix Released
Low
Stephen Lyons

Bug Description

getAreaExits() is supposed to list the room IDs in an area that have exits, normal or otherwise, to rooms in other areas.

At the moment, the lists it is returning are wrong - it will be including rooms that aren't area edge nodes, and forgetting to return rooms that are area edge nodes, all kind of randomly and changing it whenever the map is reloaded...

Revision history for this message
Stephen Lyons (slysven) wrote :

Ah, from what I recall, the code that built up the list of exits was including the wrong end of the link for either/or/both normal and special exits - I had rolled a fix but it may have got lost in Chris's alternative (simpler) fix for the moving rooms from one area to another not taken room from old area. That was back when I was going to use area zero as a real (non-removable) holding area and Chris went with a virtual area -1 that never gets instantiated place to hold rooms that had not otherwise been allocated to a room. I'll see if I can dig out what I proposed and rework this bit of it.

Stephen Lyons (slysven)
Changed in mudlet:
assignee: nobody → Stephen Lyons (slysven)
status: Confirmed → Opinion
status: Opinion → Confirmed
Revision history for this message
Stephen Lyons (slysven) wrote :

Fix submitted in Pull Request: http://github.com/Mudlet/Mudlet/pull/219

Changed in mudlet:
status: Confirmed → In Progress
Revision history for this message
Vadim Peretokin (vperetokin) wrote :

The PR doesn't address the issue at hand.

Changed in mudlet:
assignee: Stephen Lyons (slysven) → nobody
status: In Progress → Confirmed
Revision history for this message
Chris (chrismudlet) wrote :
Changed in mudlet:
assignee: nobody → Chris (chrismudlet)
status: Confirmed → Fix Committed
Revision history for this message
Stephen Lyons (slysven) wrote :

https://github.com/Mudlet/Mudlet/pull/219 now revised and ready to merge - 225 no longer required I believe.

Changed in mudlet:
status: Fix Committed → In Progress
Changed in mudlet:
status: In Progress → Fix Committed
assignee: Chris (chrismudlet) → nobody
assignee: nobody → Stephen Lyons (slysven)
Changed in mudlet:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.