OpenStack Identity (keystone)

a tiny issue in docstring

Bug #1380477 reported by Kun Huang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Rodrigo Duarte
OpenStack Identity (keystone) 2015.1.0 "kilo"

Bug Description

This line[0] should not be "Start a WSGI server in a new green thread." I think.

The truth is the python process spawn many green threads to handle incoming request from a greenlet pool. So the WSGI server itself should be a normal python process[1], but the handling jobs is in green thread (greenlet). I think we could say "Start a WSGI server with a new green thread pool" or something else.

Above is from my understanding for os-thread and green thread, maybe with some mistakes.

[0] https://github.com/openstack/keystone/blob/master/keystone/common/environment/eventlet_server.py#L177
[1] https://github.com/eventlet/eventlet/blob/master/eventlet/wsgi.py#L781-L801

Dolph Mathews (dolph)
tags: added: documentation low-hanging-fruit
Changed in keystone:
importance: Undecided → Low
Morgan Fainberg (mdrnstm)
Changed in keystone:
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/128496

Changed in keystone:
assignee: nobody → Rodrigo Duarte (rodrigodsousa)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/128496
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=3b8752080a1089c885c002b1c41b5cc8ad3e6a57
Submitter: Jenkins
Branch: master

commit 3b8752080a1089c885c002b1c41b5cc8ad3e6a57
Author: Rodrigo Duarte Sousa <email address hidden>
Date: Tue Oct 14 23:20:05 2014 -0300

    Fixes docstring at eventlet_server

    The WSGI server is a normal process (not a thread as being
    described in the docstring), it uses a green thread pool though,
    to handle upcoming jobs.

    Change-Id: I688175eeaccd4c1aa4b2ee5564745b502b9cb748
    Closes-Bug: 1380477

Changed in keystone:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (feature/hierarchical-multitenancy)

Fix proposed to branch: feature/hierarchical-multitenancy
Review: https://review.openstack.org/138182

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (feature/hierarchical-multitenancy)

Change abandoned by Morgan Fainberg (<email address hidden>) on branch: feature/hierarchical-multitenancy
Review: https://review.openstack.org/138182

Morgan Fainberg (mdrnstm)
Changed in keystone:
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.