Large blocks of text are difficult to read in Horizon

Bug #1379565 reported by Janet Yu
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
congress
Fix Released
Medium
Janet Yu

Bug Description

Policy rule definitions and data source rows are currently not very human-readable in Horizon. Ideas - Break up rules with something like: https://github.com/stackforge/python-congressclient/blob/master/congressclient/osc/v1/policy.py#L30. Split up data from rows into separate columns.

Revision history for this message
Janet Yu (jwy) wrote :

Example policy rule:

error(name2) :- neutron:ports(a, b, c, d, e, f, g, network_id, tenant_id, j, k, l, m, n, device_id, p), nova:servers(device_id, name2, c2, d2, tenant_id2, f2, g2, h2), neutron:networks(a3, b3, c3, d3, e3, tenant_id3, g3, h3, i3, network_id, k3), not same_group(tenant_id, tenant_id2)

Example policy data table row:

[u'b4039d7b-0d25-4107-9de5-194baceec8b6', u'508c5f29-5174-4b0d-8abd-4d4eaa385d9d', u'0d59d637-b02f-4c21-a4bb-fd9f4cdf0fa6', u'None', u'ACTIVE', u'', u'True', u'2db740bc-a201-4793-adc0-5cb762c6256b', u'50b434338990416ab36b89e6e73a363a', u'ovs', u'compute:None', u'fa:16:3e:66:a6:25', u'd08d5184-87d1-4255-b235-73b3991b8b2e', u'b60cb01e-3392-42de-8c07-96040972533d', u'246c8b94-4364-40c5-a241-0efacffd2b77', u'openstack']

Tim Hinrichs (thinrichs)
Changed in congress:
importance: Undecided → Medium
Janet Yu (jwy)
Changed in congress:
assignee: nobody → Janet Yu (jwy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to congress (master)

Fix proposed to branch: master
Review: https://review.openstack.org/141976

Changed in congress:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to congress (master)

Reviewed: https://review.openstack.org/141976
Committed: https://git.openstack.org/cgit/stackforge/congress/commit/?id=a9e9da9754f39d4d7d981062da7e763ef122f5cd
Submitter: Jenkins
Branch: master

commit a9e9da9754f39d4d7d981062da7e763ef122f5cd
Author: Janet Yu <email address hidden>
Date: Mon Dec 15 20:01:46 2014 -0800

    Prettify policy and data source tables in Horizon

    Break up policy rules into multiple lines and data source tables into multiple
    columns.

    horizon/
    * congress.py: New constants used to parse rules for formatting. Use the full
      string for PolicyAPIDictWrapper names by default. Add new function to delete
      values from apidict. Add PolicyRule class. Return None for objects not found
      instead of empty apidict. Change some names and add docstrings for clarity.

    horizon/datasources/
    * tables.py: Fix indentation. Change class name for clarity.
    * views.py: Fix exception handling - exceptions.handle() only works with
      certain types of exceptions. Remove sorting of policies tables, which may
      take a while for a long list. Split plugin and plugin-derived policy data
      tables into columns based on the table's schema. Split user policy data
      tables into unnamed columns. Add data source type to details view.

    horizon/datasources/templates/datasources/
    * _detail_overview.html: Show data source type. Remove condition for showing
      table name.

    horizon/policies/
    * tables.py: Split policy rules into multiple lines.
    * views.py: Fix exception handling - exceptions.handle() only works with
      certain types of exceptions.

    Change-Id: If289cea3b8e5cbe03628011143d81f31ccc292a8
    Closes-Bug: 1379565

Changed in congress:
status: In Progress → Fix Committed
Tim Hinrichs (thinrichs)
Changed in congress:
milestone: none → kilo-3
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.