Worker hangs with private repo and https url

Bug #1378386 reported by Melissa Kam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Solum
Triaged
High
Unassigned

Bug Description

If a plan file uses a private repo but the href for the repo is the https clone url instead of the ssh clone url, the worker hangs while waiting for a username/password input when unit testing.

Sample Plan File:
version: 1
name: private_https_url
description: Testing private with https url.
artifacts:
- name: https
  artifact_type: heroku
  content:
    href: https://github.com/private/repo
    private: True
  language_pack: auto
  unittest_cmd: sh unit_tests.sh

solum assembly create https_bug <plan_uri>

Logs:
2014-10-07 14:21:35.811 12320 DEBUG barbicanclient.client [-] Response status 200 _check_status_code /opt/stack/python-barbicanclient/barbicanclient/client.py:193
2014-10-07 14:21:35.821 12320 DEBUG solum.worker.handlers.shell [-] Unittest logs stored at /var/log/solum/worker/07ca8476-3a29-4841-bbfb-240bbdc05879.log _run_unittest /opt/stack/solum/solum/worker/handlers/shell.py:256
Identity added: /dev/shm/solum/xtfam.../.creds (/dev/shm/solum/xtfam.../.creds)
Username for 'https://github.com':

Tags: solum-worker
Revision history for this message
Devdatta Kulkarni (devdatta-kulkarni) wrote :

@melissa-kam So currently we are supporting only ssh protocol for git for private repositories. Is that correct? If so, we need to update our documentation

https://solum.readthedocs.org/en/latest/getting_started/index.html

In fact, the above documentation also needs to be updated with discussion about supporting private git repositories.

Revision history for this message
Melissa Kam (melissa-kam) wrote :

Yes, we're only supporting the ssh clone url. Solum should verify when creating the app that if the repo is private, the url should be in ssh form.

Revision history for this message
Adrian Otto (aotto) wrote :

It sounds like the defect is that we are not enforcing the correct input validation on content/href in the YAML content.

Changed in solum:
status: New → Triaged
importance: Undecided → Low
milestone: none → 2015.1.1
tags: added: solum-worker
Changed in solum:
importance: Low → High
milestone: 2015.1.1 → next-mitaka
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.