OpenStack Compute (nova)

Hard-reboots ignore root_device_name

Bug #1378132 reported by Nicolas Simonds
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Nicolas Simonds
OpenStack Compute (nova) 2015.1.0 "kilo"
Juno
Fix Released
Undecided
Unassigned
OpenStack Compute (nova) 2014.2.4

Bug Description

Hard-rebooting an instance causes the root_device_name to get ignored/reset, which can cause wailing and gnashing of teeth if the guest operating system is expecting it to not do that.

Steps to reproduce:

1. Stand up a devstack
2. Load the openrc with admin credentials
3. glance image-update --property root_device_name=sda SOME_CIRROS_IMAGE
4. Spawn a cirros instance using the above image. The root filesystem should present as being mounted on /dev/sda1, and the libvirt.xml should show the disk with a target of "scsi"
5. Hard-reboot the instance

Expected Behaviour

The instance comes back up with the same hardware configuration as it had when initially spawned, i.e., with its root filesystem attached to a SCSI bus

Actual Behaviour

The instance comes back with its root filesystem attached to an IDE bus.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/126437

Changed in nova:
assignee: nobody → Nicolas Simonds (nicolas.simonds)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/126437
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

melanie witt (melwitt)
Changed in nova:
importance: Undecided → Medium
tags: added: compute
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/126437
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ee435b4267b18eb910f7169792ea62244905733a
Submitter: Jenkins
Branch: master

commit ee435b4267b18eb910f7169792ea62244905733a
Author: Nicolas Simonds <email address hidden>
Date: Mon Oct 6 15:24:58 2014 -0700

    Make _get_instance_block_device_info preserve root_device_name

    On hard reboots,
    nova.compute.manager.ComputeManager._get_instance_block_device_info will
    faithfully reconstruct all of the block_device_info attributes that
    the instance needs, except for the root_device_name. This causes
    the instance to effectively lose its disk configurations on hard
    reboots.

    This patch set will preserve the root_device_name if it is defined
    for the instance.

    Closes-Bug: #1378132
    Change-Id: Ia36b1d6170ad120f794aa16d41ed4275b4b11f22

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-2 → 2015.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/189209

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/juno)

Reviewed: https://review.openstack.org/189209
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3b62ab5e40e949e4f2431d3db985c8f2c20d70b5
Submitter: Jenkins
Branch: stable/juno

commit 3b62ab5e40e949e4f2431d3db985c8f2c20d70b5
Author: Nicolas Simonds <email address hidden>
Date: Mon Oct 6 15:24:58 2014 -0700

    Make _get_instance_block_device_info preserve root_device_name

    On hard reboots,
    nova.compute.manager.ComputeManager._get_instance_block_device_info will
    faithfully reconstruct all of the block_device_info attributes that
    the instance needs, except for the root_device_name. This causes
    the instance to effectively lose its disk configurations on hard
    reboots.

    This patch set will preserve the root_device_name if it is defined
    for the instance.

    Conflicts:
     nova/tests/unit/compute/test_compute.py

    (cherry picked from commit ee435b4267b18eb910f7169792ea62244905733a)

    Closes-Bug: #1378132
    Change-Id: Ia36b1d6170ad120f794aa16d41ed4275b4b11f22

tags: added: in-stable-juno
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.