neutron

router-gateway-clear binds router to agents

Bug #1378066 reported by Ed Bak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
ZongKai LI
neutron 2015.1.0 "kilo"

Bug Description

1) Create a router: neutron router-create test
2) Expect no router bindings with:

neutron l3-agent-list-hosting-router

3) Clear the gateway: neutron router-gateway-clear test
4) Expect no router bindings with:

neutron l3-agent-list-hosting-router

This time the command shows that the router is bound to an agent(s).

In the DVR case, this is particularly bad, as the binding may cause namespace creations on the hosts running the L3 agents.

See original description
Armando Migliaccio (armando-migliaccio)
Changed in neutron:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

I was unable to verify that the namespace is provisioned, but the binding is certainly there.

Bear in mind, that clearing a gateway on a router creates the binding even for *NON* DVR routers.

Armando Migliaccio (armando-migliaccio)
summary: - router-gateway-clear creates a namespace and binding on every compute
- node
+ router-gateway-clear binds router to agents
Armando Migliaccio (armando-migliaccio)
description: updated
Xurong Yang (idopra)
Changed in neutron:
assignee: nobody → Xurong Yang (idopra)
Revision history for this message
Xurong Yang (idopra) wrote :

Clearing gateway will trigger router updating, which will schedule the router to an agent, thus the binding is created. Not sure if this binding is needed since the router may have other interfaces attached to it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/159338

Changed in neutron:
assignee: Xurong Yang (idopra) → ZongKai LI (lzklibj)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by ZongKai LI (<email address hidden>) on branch: master
Review: https://review.openstack.org/159338
Reason: This overlaps with https://review.openstack.org/#/c/152845

Revision history for this message
ZongKai LI (zongkai) wrote :

Fix patch : https://review.openstack.org/#/c/152845
Its UT still have some work to do.

Kyle Mestery (mestery)
Changed in neutron:
milestone: none → kilo-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/159338
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e99f6e00cfd397bb74d44c9462dfcfa545dbed8c
Submitter: Jenkins
Branch: master

commit e99f6e00cfd397bb74d44c9462dfcfa545dbed8c
Author: lzklibj <email address hidden>
Date: Wed Feb 25 21:19:07 2015 -0800

    fix check_ports_exist_on_l3agent in no subnet case

    If no subnets attached to the given router, this check
    should return False.

    Currently, if no subnets attached to given router, the
    following process in this method will fetch all ports
    to continue its checking, consider those ports are not
    related to the given router, the following checking
    should be invalid.

    To issue #1378066, after running "router-gateway-clear",
    _schedule_router will be triggered, and the invalid
    checking will make processing in get_candidates believe
    that all l3-agents are valid to schedule this router,
    and finally, invalid records are inserted into table
    RouterL3AgentBindings.

    Closes-Bug: #1378066
    Closes-Bug: #1417908
    Closes-Bug: #1420032

    Change-Id: If96d866c831330cca68a5fe5a0f27f178bbf40a6

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.